Home > mailing lists

Re: Use WALReadFromBuffers in more places - Mailing list pgsql-hackers

From	Jingtang Zhang
Subject	Re: Use WALReadFromBuffers in more places
Date	October 15, 2024 11:22:32
Msg-id	CAPsk3_A7079UtVqm2WXXiwadGJ7DucpenmLwnXZgDgXee703Rw@mail.gmail.com Whole thread Raw
In response to	Re: Use WALReadFromBuffers in more places (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List	pgsql-hackers

Hi all.

I've been back to this patch for a while recently. I witness that if a WAL

writer works fast, the already flushed WAL buffers will be zeroed out and

re-initialized for future use by AdvanceXLInsertBuffer in

XLogBackgroundFlush, so that WALReadFromBuffers will miss even though the

space of WAL buffer is enough. It is much more unfriendly for logical

walsenders than physical walsenders, because logical ones consume WAL

slower than physical ones due to the extra decoding phase. Seems that the aim

of AdvanceXLInsertBuffer in WAL writer contradicts with our reading from

WAL buffer. Any thoughts?

From: David Rowley
Date: 15 October 2024, 11:20:48
Subject: Re: [PATCH] Move clause_sides_match_join() into pathnode.h

From: Artur Zakirov
Date: 15 October 2024, 11:45:23
Subject: Re: type cache cleanup improvements