Re: Protecting allocator headers with Valgrind - Mailing list pgsql-hackers

From David Rowley
Subject Re: Protecting allocator headers with Valgrind
Date
Msg-id CAApHDvrV7WQ2dqJeT2i3HFPK3UFoadafRdDoE6W7H=P=_dmQSQ@mail.gmail.com
Whole thread Raw
In response to Re: Protecting allocator headers with Valgrind  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
On Sun, 16 Apr 2023 at 03:26, Noah Misch <noah@leadboat.com> wrote:
> Not objecting.  I think the original Valgrind integration refrained from this
> because it would have added enough Valgrind client requests to greatly slow
> Valgrind runs.  Valgrind reduced the cost of client requests in later years,
> so this new conclusion is reasonable.

I tested that. It's not much slowdown:

time make installcheck

Unpatched: real    79m36.458s
Patched: real    81m31.589s

I forgot to mention, I pushed the patch yesterday.

David



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: idea: multiple arguments to_regclass function
Next
From: Mikael Kjellström
Date:
Subject: Re: Direct I/O