Re: BUG #17777: An assert failed in nodeWindowAgg.c - Mailing list pgsql-bugs

From David Rowley
Subject Re: BUG #17777: An assert failed in nodeWindowAgg.c
Date
Msg-id CAApHDvrfuSuFq57EtbYxHNWYhMET9K_TpSefDUoM52-T6LCYbg@mail.gmail.com
Whole thread Raw
In response to Re: BUG #17777: An assert failed in nodeWindowAgg.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BUG #17777: An assert failed in nodeWindowAgg.c
Re: BUG #17777: An assert failed in nodeWindowAgg.c
List pgsql-bugs
On Mon, 13 Feb 2023 at 05:19, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Why is it okay to check only the filter, and not the rest of the
> WindowFunc's subexpressions?  The arguments we've just run through
> seem to apply to a subplan in the direct or aggregated arguments
> as well.

Good point.  I had just been thinking in terms of the reported bug to
make sure we inverse transition the same rows we transition. We also
need to make sure the transition value matches in both transition
directions.

I've adjusted the patch accordingly.

David

Attachment

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #17788: Incorrect memory access when parsing empty string as sql_standard interval
Next
From: Andres Freund
Date:
Subject: Re: BUG #17777: An assert failed in nodeWindowAgg.c