Re: Some messages of pg_rewind --debug not getting translated - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Some messages of pg_rewind --debug not getting translated
Date
Msg-id CAB7nPqQ2tJvAV+XgCz5SV1Nwywy_jfmvAxVEw9GyFgPvAmMXNg@mail.gmail.com
Whole thread Raw
In response to Re: Some messages of pg_rewind --debug not getting translated  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Some messages of pg_rewind --debug not getting translated
List pgsql-hackers
On Wed, Mar 23, 2016 at 12:24 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Seems reasonable.  For the last hunk in your patch, though, I would add
> a /* translator: */ comment explaining what each of the values is;
> otherwise it's just incomprehensible percent-sign-salad for the poor
> translator.  Note that if the line is too long you have to use dirty
> tricks to avoid pgindent from messing it up (see 673b52753489 for
> example)

OK, done this way.

> I'm not sure if we should keep "blk" in the original or make it a
> complete word.

OK, a complete word makes more sense.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: 2PC support for pglogical
Next
From: Pavan Deolasee
Date:
Subject: pg_xlogdump fails to handle WAL file with multi-page XLP_FIRST_IS_CONTRECORD data