Postgres Pro
Downloads
Home   >   mailing lists

Re: Incorrect initialization of sentPtr in walsender.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Incorrect initialization of sentPtr in walsender.c
Date
Msg-id CAB7nPqR1tzEpzY3VBg3Nsk5w_q6+wtspiOkXAM2HSu36pHz_LQ@mail.gmail.com
Whole thread Raw
In response to Incorrect initialization of sentPtr in walsender.c  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Incorrect initialization of sentPtr in walsender.c
List pgsql-hackers
Tree view 
On Fri, Sep 12, 2014 at 9:08 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> In walsender.c, sentPtr is initialized as follows:
> static XLogRecPtr sentPtr = 0;
> Isn't that incorrect and shouldn't we use InvalidXLogRecPtr instead?
Actually by looking more around I found a couple of extra places where
the same inconsistencies are present, mainly in xlog.c and
walreceiver.c. Updated patch attached for all those things.
Regards,
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Incorrect initialization of sentPtr in walsender.c
Next
From: Peter Geoghegan
Date:
Subject: Re: B-Tree support function number 3 (strxfrm() optimization)