Re: In-core regression tests for replication, cascading, archiving, PITR, etc. - Mailing list pgsql-hackers

<div dir="ltr"><br /><div class="gmail_extra"><br /><div class="gmail_quote">On Fri, Sep 25, 2015 at 3:11 PM, Amir
Rohan<span dir="ltr"><<a href="mailto:amir.rohan@mail.com" target="_blank">amir.rohan@mail.com</a>></span>
wrote:<br/><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div
class="HOEnZb"><divclass="h5">On 08/14/2015 06:32 AM, Michael Paquier wrote:<br /> > On Fri, Aug 14, 2015 at 12:54
AM,Michael Paquier<br /> > <<a href="mailto:michael.paquier@gmail.com">michael.paquier@gmail.com</a>>
wrote:<br/> >> On Mon, Jun 29, 2015 at 10:11 PM, Michael Paquier<br /> >> <<a
href="mailto:michael.paquier@gmail.com">michael.paquier@gmail.com</a>>wrote:<br /> >>> On Wed, Mar 18, 2015
at1:59 PM, Michael Paquier<br /> >>> <<a
href="mailto:michael.paquier@gmail.com">michael.paquier@gmail.com</a>>wrote:<br /> >>>> Feedback is of
coursewelcome, but note that I am not seriously<br /> >>>> expecting any until we get into 9.6 development
cycleand I am adding<br /> >>>> this patch to the next CF.<br /> >>> I have moved this patch to CF
2015-09,as I have enough patches to<br /> >>> take care of for now... Let's focus on Windows support and
improvement<br/> >>> of logging for TAP in the first round. That will be already a good<br /> >>>
stepforward.<br /> >> OK, attached is a new version of this patch, that I have largely<br /> >> reworked to
havemore user-friendly routines for the tests. The number<br /> >> of tests is still limited still it shows what
thisfacility can do:<br /> >> that's on purpose as it does not make much sense to code a complete<br /> >>
andcomplicated set of tests as long as the core routines are not<br /> >> stable, hence let's focus on that
first.<br/> >> I have not done yet tests on Windows, I am expecting some tricks<br /> >> needed for the
archiveand recovery commands generated for the tests.<br /> > Attached is v3. I have tested and fixed the tests such
asthey can run<br /> > on Windows. archive_command and restore_command are using Windows'<br /> > copy when
needed.There was also a bug with the use of a hot standby<br /> > instead of a warm one, causing test 002 to
fail.<br/> > I am rather happy with the shape of this patch now, so feel free to review it...<br /> > Regards,<br
/><br/></div></div>Michael, I've ran these and it worked fine for me.<br /> See attached patch with a couple of minor
fixes.<spanclass="HOEnZb"><font color="#888888"><br /></font></span></blockquote></div><br /></div><div
class="gmail_extra">Thanks!I still think that we could improve a bit more the way parametrization is done in
postgresql.confwhen a node is initialized by appending a list of parameters or have a set of hardcoded behaviors
includinga set of default parameters and their values... But well feedback is welcome regarding that. I also arrived at
theconclusion that it would be better to place the new package file in src/test/perl instead of src/test/recovery to
allowany users of the TAP tests to have it in their PERL5LIB path and to be able to call the new routines to create and
manipulatenodes.<br />-- <br /><div class="gmail_signature">Michael<br /></div></div></div>