Re: Conflict detection for update_deleted in logical replication - Mailing list pgsql-hackers

From Xuneng Zhou
Subject Re: Conflict detection for update_deleted in logical replication
Date
Msg-id CABPTF7U8SKpw+Hepd4MJ+oPBAWdFmYukyk92TKLkZGHhQD4KaQ@mail.gmail.com
Whole thread Raw
In response to Re: Conflict detection for update_deleted in logical replication  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers

Hi Zhijie,


Thanks for the effort on the patches. I did a quick look on them before diving into the logic and discussion. Below are a few minor typos found in version 31.



1. Spelling of “non-removable”


 [PATCH v31 1/7] 

 In docs and code “removeable” vs. “removable” are used alternatively and omitted the hyphen in “non-removable”.



2. Double “arise” in SGML


[PATCH v31 7/7]

 In doc/src/sgml/logical-replication.sgml under the <varlistentry id="conflict-update-deleted">, have duplicate arise:


+       are enabled. Note that if a tuple cannot be found due to the table being
+       truncated only a <literal>update_missing</literal> conflict will arise.
+       arise



3. Commit-message typos


[PATCH v31 1/7] (typo “tranasction”)

Subject: [PATCH v30 1/7] Maintain the oldest non removeable tranasction ID by
 apply worker

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Random subscription 021_twophase test failure on kestrel
Next
From: Andres Freund
Date:
Subject: Re: Understanding when VM record needs snapshot conflict horizon