Re: Mail thread references in commits - Mailing list pgsql-hackers
From | Magnus Hagander |
---|---|
Subject | Re: Mail thread references in commits |
Date | |
Msg-id | CABUevEwnimVJY2yrFBMvaUwBf98PGjd=RNJT5w23Rsz-rFJzyw@mail.gmail.com Whole thread Raw |
In response to | Re: Mail thread references in commits (Andrew Dunstan <andrew@dunslane.net>) |
Responses |
Re: Mail thread references in commits
|
List | pgsql-hackers |
<p dir="ltr"><p dir="ltr">On Nov 19, 2016 15:33, "Andrew Dunstan" <<a href="mailto:andrew@dunslane.net">andrew@dunslane.net</a>>wrote:<br /> ><br /> ><br /> ><br /> > On 11/19/201607:36 AM, Stephen Frost wrote:<br /> >><br /> >> Magnus,<br /> >><br /> >> * Magnus Hagander(<a href="mailto:magnus@hagander.net">magnus@hagander.net</a>) wrote:<br /> >>><br /> >>> On Sat,Nov 19, 2016 at 1:07 AM, Stephen Frost <<a href="mailto:sfrost@snowman.net">sfrost@snowman.net</a>> wrote:<br />>>>><br /> >>>> * Magnus Hagander (<a href="mailto:magnus@hagander.net">magnus@hagander.net</a>)wrote:<br /> >>>>><br /> >>>>> Itwould make the URLs actually short, but as mentioned upthread, that<br /> >>>>> wouldn't work at all ifoffline. So it'd be a tradeoff between those, but<br /> >>>>> so are pretty much all other options thatdon't include the full<br /> >>>><br /> >>>> message-id.<br /> >>>><br /> >>>>This is a bit of a crazy idea, but in the new list system, couldn't we<br /> >>>> add a headerwhich includes "our" surrogate message-id? Or possibly the<br /> >>>> entire URL to the message, and maybethe URL for the entire thread?<br /> >>><br /> >>> I'd rather not tie those systems in that tightly.I think they are much<br /> >>> better off being de-coupled.<br /> >><br /> >> I get that, but...<br/> >><br /> >>> That said, what we could do is invent our own "id". We could either use a<br /> >>>separate surrogate key, or we could do the sha-1 hash of the messageid. And<br /> >>> stick that ina header, which could then be searched for both locally and<br /> >>> remotely.<br /> >><br /> >>Yeah, that's a good thought too. I think we'd need to use a SHA1 to<br /> >> avoid collisions which meansthat it'll be a bit longer than if we used<br /> >> an actual ID, but it shouldn't be *too* long.<br /> >><br/> ><br /> ><br /> > I can think of at least one scenario where you might not easily have access to anyinvented ID - you're the author and you have mailing list me-too turned off, so you don't have anything that the mailinglist has inserted. I honestly think we should just stick with the Message-ID value and get over the ugliness.<br />><br /> > Putting the clickable URL in a header("X-Archive-Link" ?) is a good idea, though. Using my MUA (Thunderbird)that would make it as simple to get as View Source (Ctrl-U) and a simple C&P, which would make committers'lives easy. I bet others might appreciate it too.<br /><p dir="ltr">As a thunderbird user you might be interestedin something like <a href="https://github.com/mhagander/pgarchives">https://github.com/mhagander/pgarchives</a>. I don't know if it works withmodern versions of thunderbird, but hopefully it does. And would be more convenient than the view source way.. <p dir="ltr">/Magnus
pgsql-hackers by date: