Re: run pgindent on a regular basis / scripted manner - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: run pgindent on a regular basis / scripted manner
Date
Msg-id CABUevEzScu5QBrrmT8fCygM-dAL+B8VD7YoyvzcAeKdNJkX4sA@mail.gmail.com
Whole thread Raw
In response to Re: run pgindent on a regular basis / scripted manner  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: run pgindent on a regular basis / scripted manner
List pgsql-hackers


On Tue, Feb 7, 2023 at 1:56 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Tue, Feb 7, 2023 at 5:16 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>
> On 2023-02-06 Mo 23:43, Noah Misch wrote:
>
>
> Well, we did talk about adding a pre-commit hook to the repository, with
> instructions for how to enable it. And I don't see a problem with adding the
> pre-receive we're discussing here to src/tools/something.
>
> Yeah.  I don't think we are seriously considering putting any restrictions
> in place on gitmaster
>
> I could have sworn that was exactly what we were discussing, a pre-receive
> hook on gitmaster.
>
>
> That's one idea that's been put forward, but it seems clear that some people are nervous about it.
>
> Maybe a better course would be to continue improving the toolset and get more people comfortable with using it locally and then talk about integrating it upstream.
>

Yeah, that sounds more reasonable to me as well.

If we wanted something "in between" we could perhaps also have a async ci job that runs after each commit and sends an emali to the committer if the commit doesn't match up, instead of rejecting it hard but still getting some relatively fast feedback.

--

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: run pgindent on a regular basis / scripted manner
Next
From: torikoshia
Date:
Subject: Allow auto_explain to log plan duration and buffer usage