Postgres Pro
Downloads
Home   >   mailing lists

Re: test_extensions: fix inconsistency between meson.build and Makefile - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Re: test_extensions: fix inconsistency between meson.build and Makefile
Date
Msg-id CABwTF4Wz41pNMJ9q3tpH=6mnvg6aopDU5Lzvers5=6=WJVekww@mail.gmail.com
Whole thread Raw
In response to Re: test_extensions: fix inconsistency between meson.build and Makefile  ("Tristan Partin" <tristan@neon.tech>)
Responses Re: test_extensions: fix inconsistency between meson.build and Makefile
List pgsql-hackers
Tree view 
On Fri, Jun 16, 2023 at 1:56 PM Tristan Partin <tristan@neon.tech> wrote:
>
> On Fri Jun 16, 2023 at 3:29 PM CDT, Jeff Davis wrote:
> > Patch attached. Currently, the Makefile specifies NO_LOCALE=1, and the
> > meson.build does not.
>
> Looks alright to me, but it might be nicer to change the order of
> arguments to match contrib/unaccent/meson.build:40. Might help with
> grepping in the future.

It seems that Jeff's patch tried to match the precedent set in
src/test/modules/test_oat_hooks/meson.build.

No matter which ordering Jeff's patch uses, it will be inconsistent
with one of the existing order of the options.

So attached is updated patch that makes the order consistent across
all 3 occurrences.

Best regards,
Gurjeet
http://Gurje.et
Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: run pgindent on a regular basis / scripted manner
Next
From: Evan Jones
Date:
Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific