confusing message in check_tuple - Mailing list pgsql-hackers

From jian he
Subject confusing message in check_tuple
Date
Msg-id CACJufxFx-25XQV+r23oku7ZnL958P30hyb9cFeYPv6wv7yzCCw@mail.gmail.com
Whole thread Raw
Responses Re: confusing message in check_tuple
List pgsql-hackers
hi.

in contrib/amcheck/verify_heapam.c, check_tuple
        report_corruption(ctx,
                          psprintf("number of attributes %u exceeds
maximum expected for table %u",
                                   ctx->natts,
                                   RelationGetDescr(ctx->rel)->natts));
i think it should be
        report_corruption(ctx,
                          psprintf("number of attributes %u exceeds
maximum expected for table %u",
                                   ctx->natts,
                                   RelationGetRelid(ctx->rel)));

or we can rephrase it another way, also mentioning
``RelationGetDescr(ctx->rel)->natts``.



pgsql-hackers by date:

Previous
From: Noboru Saito
Date:
Subject: Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths
Next
From: Peter Eisentraut
Date:
Subject: Re: Possibly hard-to-read message