Re: confusing message in check_tuple - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: confusing message in check_tuple
Date
Msg-id 41ea2006-4d0a-4de3-ac10-c99d31be5e72@eisentraut.org
Whole thread Raw
In response to confusing message in check_tuple  (jian he <jian.universality@gmail.com>)
Responses Re: confusing message in check_tuple
Re: confusing message in check_tuple
List pgsql-hackers
On 12.06.25 08:26, jian he wrote:
> in contrib/amcheck/verify_heapam.c, check_tuple
>          report_corruption(ctx,
>                            psprintf("number of attributes %u exceeds
> maximum expected for table %u",
>                                     ctx->natts,
>                                     RelationGetDescr(ctx->rel)->natts));

Agreed this is misleading.

> i think it should be
>          report_corruption(ctx,
>                            psprintf("number of attributes %u exceeds
> maximum expected for table %u",
>                                     ctx->natts,
>                                     RelationGetRelid(ctx->rel)));
> 
> or we can rephrase it another way, also mentioning
> ``RelationGetDescr(ctx->rel)->natts``.

I think they did want to mention RelationGetDescr(ctx->rel)->natts.  How 
about

"number of attributes %u exceeds maximum expected for table (%u)"




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: fix: propagate M4 env variable to flex subprocess
Next
From: Peter Eisentraut
Date:
Subject: Re: wrong comments in rewriteTargetListIU