Re: Check for existing replication slot in pg_createsubscriber - Mailing list pgsql-hackers

From Zane Duffield
Subject Re: Check for existing replication slot in pg_createsubscriber
Date
Msg-id CACMiCkUDUz8ur++ACBvTMMUfPwkkD6n2dz-ng-SndRBLXXZsCQ@mail.gmail.com
Whole thread Raw
In response to Re: Check for existing replication slot in pg_createsubscriber  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Mon, Jun 30, 2025 at 1:15 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
One thing I was
thinking is whether it makes sense to add these checks only in
--dry-run mode because we normally don't expect such conflicts.
Otherwise, each such check adds an additional network round-trip.

I did wonder why it bothered checking for conflicts before running the command that would fail in case of a conflict.
It makes sense to me to only check for conflicts in --dry-run mode.

Thanks,
Zane

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Check for existing replication slot in pg_createsubscriber
Next
From: Dilip Kumar
Date:
Subject: Re: Replace magic numbers with strategy numbers for B-tree indexes