Re: Patch to add regression tests for SCHEMA - Mailing list pgsql-hackers

From Robins Tharakan
Subject Re: Patch to add regression tests for SCHEMA
Date
Msg-id CAEP4nAyEJQp1VF8aJq0nknT8x+KFy8rLagBgpyv04xENhDYmrg@mail.gmail.com
Whole thread Raw
In response to Re: Patch to add regression tests for SCHEMA  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: Patch to add regression tests for SCHEMA
Re: Patch to add regression tests for SCHEMA
List pgsql-hackers
Hi,

Please find attached an updated patch with the said changes.
I'll try to update the other patches (if they pertain to this feedback) and update on their respective threads (as well as on Commitfest).

--
Robins Tharakan


On 8 May 2013 13:01, Fabien COELHO <coelho@cri.ensmp.fr> wrote:

Dear Robins,


Here is an updated patch that uses different schema / role names for
different tests (as per commitfest site feedback).

Short review about this version of the patch:

This patch work for me.

This test is a good thing and allows schema to be thoroughly tested, including corner cases which must fail because of errors or permissions.

Two remarks:

 - test 2 bis: why name 'pg_asdf'? why not 'pg_schema_sch<some number>'
   to be homogeneous with other tests?

 - test 3: why not WHERE schema_name='schema_sch3' instead of two
   negative comparisons? ISTM that if for some reason in the future a new
   schema name is added, the test will fail.

--
Fabien.

Attachment

pgsql-hackers by date:

Previous
From: Robins Tharakan
Date:
Subject: Re: Add regression tests for COLLATE
Next
From: Peter Eisentraut
Date:
Subject: Re: improving PL/Python builds on OS X