Re: Small miscellaneus fixes (Part II) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Small miscellaneus fixes (Part II)
Date
Msg-id CAEudQAr+vQUDF1KXucG0B2+cBjPDFUZY8hsS1_660hpaE=0-cg@mail.gmail.com
Whole thread Raw
In response to Re: Small miscellaneus fixes (Part II)  (John Naylor <john.naylor@enterprisedb.com>)
List pgsql-hackers
Em seg., 16 de jan. de 2023 às 03:28, John Naylor <john.naylor@enterprisedb.com> escreveu:

I wrote:
> ...but arguably the earlier check is close enough that it's silly to assert in the "else" branch, and I'd be okay with just nuking those lines. Another thing that caught my attention is the assumption that unsetting a bit is so expensive that we have to first check if it's set, so we may as well remove "IS_BRACKET(Np->Num)" as well.

The attached is what I mean. I'll commit this this week unless there are objections.
+1 looks good to me.

regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Allow tailoring of ICU locales with custom rules
Next
From: Juan José Santamaría Flecha
Date:
Subject: Re: Using AF_UNIX sockets always for tests on Windows