Re: pg_dump --no-comments confusion - Mailing list pgsql-hackers

From Matthias van de Meent
Subject Re: pg_dump --no-comments confusion
Date
Msg-id CAEze2Wjo2zbEzv5=Q=cr6hkKW+Vchg5xj44cpB8oXGqwjK1rYQ@mail.gmail.com
Whole thread Raw
In response to pg_dump --no-comments confusion  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Mon, 4 Nov 2024 at 21:00, Bruce Momjian <bruce@momjian.us> wrote:
>
> On Mon, Nov  4, 2024 at 07:49:45PM +0100, Daniel Gustafsson wrote:
> > > On 4 Nov 2024, at 17:24, Erik Wienhold <ewie@ewie.name> wrote:
> > > But I also think that
> > > "SQL" in front of the command name is unnecessary because the man page
> > > uses the "FOOBAR command" form throughout
> >
> > Agreed.
> >
> > >    --inserts
> > >        Dump data as INSERT commands [...]
> > >
> > > Also, it doesn't really matter whether COMMENT is standard SQL.
> >
> > AFAIK some flavor of COMMENT is present in MySQL, PostgreSQL and Oracle which
> > already makes it more "standardized" than many parts of the SQL standard =)

Oh, I didn't know that, TIL.

> Proposed patch attached.

LGTM.

-Matthias



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: index_delete_sort: Unnecessary variable "low" is used in heapam.c
Next
From: Nikolay Samokhvalov
Date:
Subject: Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE