Re: v3.0 release on hold - Mailing list pgadmin-hackers

On Thu, Mar 22, 2018 at 9:58 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Thu, Mar 22, 2018 at 3:20 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Thu, Mar 22, 2018 at 9:25 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi Dave,

On Wed, Mar 21, 2018 at 9:05 PM, Dave Page <dpage@pgadmin.org> wrote:

We've run into a number of unexpected issues with the v3.0 release that I think we need to resolve before moving forwards. For the time being, only patches critical to fix these issues should be committed.

I'll try to look at 1, though I do have another deadline I need to meet. 

Akshay, can you look at 2 please?

Fahar is already looking at 3.

Khushboo, can you look at 4 please?

Thanks all.

1) There is no longer a system tray in Gnome 3.26 and later, and thus the runtime won't initialise in Fedora 27 and later. We need an alternative for this, either a tray replacement that the RPM can depend on, or better yet, support whatever it is Gnome expect such apps to use these days.

2) Starting a second instance of the app bundle on Mac doesn't always open a new pgAdmin window as it should. It works fine in the debugger, or if you start the app with a command like: "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click the appbundle or use a command like "open /Applications/pgAdmin\ 4.app"

3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my copy, but apparently his is a fresh installation.

4) On my Windows 7 machine, after running a backup I get no status window, and see the following in the logs:

We have tried to reproduce this issue on Windows 7 and Windows 8, but couldn't reproduce it, It is working fine on both the environments.

Can you please provide the options which you have selected while taking a backup?

They were all the default options - I just selected a database, right-clicked to select backup, and entered a filename.

 

With the default options, it is working fine. 

Can you see any  way in which the exception below could conceivably happen? Perhaps if run on a system that has process logs from an older version of pgAdmin?

 

Traceback (most recent call last):

  File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 209, in run_wsgi

    execute(self.server.app)

  File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 197, in execute

    application_iter = app(environ, start_response)

  File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1997, in __call__

    return self.wsgi_app(environ, start_response)

  File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1985, in wsgi_app

    response = self.handle_exception(e)

  File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1540, in handle_exception

    reraise(exc_type, exc_value, tb)

  File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1982, in wsgi_app

    response = self.full_dispatch_request()

  File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1614, in full_dispatch_request

    rv = self.handle_user_exception(e)

  File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1517, in handle_user_exception

    reraise(exc_type, exc_value, tb)

  File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1612, in full_dispatch_request

    rv = self.dispatch_request()

  File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1598, in dispatch_request

    return self.view_functions[rule.endpoint](**req.view_args)

  File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask_login.py", line 792, in decorated_view

    return func(*args, **kwargs)

  File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py", line 62, in index

    return make_response(response=BatchProcess.list())

  File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\processes.py", line 584, in list

    details = desc.details(p.command, args)

  File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\tools\backup\__init__.py", line 190, in details

    res += html.safe_str(cmd + self.cmd)

AttributeError: 'BackupMessage' object has no attribute 'cmd'

Thanks,

Khushboo 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company