Re: Excessive number of replication slots for 12->14 logical replication - Mailing list pgsql-bugs

On Thu, Aug 18, 2022 at 3:46 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> Looks good.
>
> I have one minor comment:
>
> -                    * SUBREL_STATE_FINISHEDCOPY. The apply worker can also
> -                    * concurrently try to drop the origin and by this time
> -                    * the origin might be already removed. For these reasons,
> -                    * passing missing_ok = true.
> +                    * SUBREL_STATE_FINISHEDCOPY. So passing missing_ok = true.
>
> I think we should change "the apply worker" to "the tablesync worker"
> but should not remove this sentence. The fact that another process
> could concurrently try to drop the origin is still true.
>
> The rest looks good to me.
>

Updated as described.

regards,
Ajin Cherian
Fujitsu Australia