Re: [pgadmin4] Edb package support. - Mailing list pgadmin-hackers

From Harshal Dhumal
Subject Re: [pgadmin4] Edb package support.
Date
Msg-id CAFiP3vyzARLrORJYop-o93fgA_u1AxNw0WfLwb_sZcJ6E0Ww5w@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin4] Edb package support.  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin4] Edb package support.
List pgadmin-hackers
Hi Dave,

-- 
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Aug 22, 2016 at 5:45 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, Aug 22, 2016 at 1:04 PM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
> PFA patch for wrong header and body were generated.
>
> Fixed the header and body sql parsing issue.

Won't this break if I have a package called issues.foo or anything
else that matches the ' is' or ' as'?
Yes, this causes issue. I have fixed it in updated patch.

Also fixed one more issue pointed by Khushboo, In some cases if we update package header it drops package body. Ideally it should not drop body.

 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Priyanka Shendge
Date:
Subject: Re: pgAdmin IV : Unittest modular patch(database child nodes) and trigger function
Next
From: Priyanka Shendge
Date:
Subject: Re: pgAdmin IV : Unittest modular patch(database child nodes) and trigger function