Postgres Pro
Downloads
Home   >   mailing lists

Re: Add regression tests for SET xxx - Mailing list pgsql-hackers

From Szymon Guz
Subject Re: Add regression tests for SET xxx
Date
Msg-id CAFjNrYtMg3cxn9Zx5rXfpRmMbVAuCkuy-1xU4WhSnEQBtDmsww@mail.gmail.com
Whole thread Raw
In response to Re: Add regression tests for SET xxx  (Robins Tharakan <tharakan@gmail.com>)
Responses Re: Add regression tests for SET xxx
Re: Add regression tests for SET xxx
Re: Add regression tests for SET xxx
List pgsql-hackers
Tree view
On 18 June 2013 02:33, Robins Tharakan <tharakan@gmail.com> wrote:
Thanks !

PFA the updated patch. Also remove a trailing whitespace at the end of SQL script.

--
Robins Tharakan


On 17 June 2013 17:29, Szymon Guz <mabewlun@gmail.com> wrote:
On 26 May 2013 19:56, Robins Tharakan <tharakan@gmail.com> wrote:
Hi,

Please find attached a patch to take code-coverage of SET (SESSION / SEED / TRANSACTION / DATESTYLE / TIME ZONE) (src/backend/commands/variable.c) from 65% to 82%.

Any and all feedback is welcome.
--
Robins Tharakan


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Hi,
the patch applies cleanly on code from trunk, however there are failing tests, diff attached.

regards
Szymon


Hi,
I've checked the patch. Applies cleanly. Tests pass this time :)

Could you add me as a reviewer to commitfest website, set this patch a reviewed and add this email to the patch history?
I cannot login to the commitfest app, there is some bug with that.

thanks,
Szymon Guz

pgsql-hackers by date:

Previous
From: Boszormenyi Zoltan
Date:
Subject: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])
Next
From: Cédric Villemain
Date:
Subject: Re: How do we track backpatches?