Re: [PATCH] fix newly added server being lost when crashing - Mailing list pgadmin-hackers
Looking good to me.
If nobody has any objection, then I can check-in.I don't know the reason for the class sysSettings to inherit the wxConfig privately in original implementation.
It was done by Dave in this commit: cfbae7d378766ab8cf138123186a024afffc061e.
On Thu, Jan 9, 2014 at 5:42 AM, Kaarel Moppel <kaarel.moppel@gmail.com> wrote:
Ok, got it. Corrected version in attach now.On Mon, Jan 6, 2014 at 12:29 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Define it only if you keep the wxConfig inherited protectively.Or,2. You don't require to define Flush function after inheriting the wxConfig class publicly.1. Please use TAB instead of 4 spacesHi Kaarel,I think - everything looks good except:On Mon, Jan 6, 2014 at 3:48 AM, Kaarel Moppel <kaarel.moppel@gmail.com> wrote:Hi,Sending some 3 small fixes in separate emails for issues that me and my colleagues found really annoying. This is my first try at Pgadmin and I haven't done too much C++ though so in case something should be corrected let me know and I'd be happy to do that.Cheers,Kaarel--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
--
--
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
pgadmin-hackers by date: