Re: [patch] Move to Alembic migration system - Mailing list pgadmin-hackers
Hi Jaoao, Sarah,
I've tried to run on fresh machine, it failed with the below error:
$ python setup.py
NOTE: Configuring authentication for SERVER mode.
Enter the email address and password to use for the initial pgAdmin user account:
Email address: ashesh.vashi@enterprisedb.com
Traceback (most recent call last):
File "setup.py", line 52, in <module>
db_upgrade(app)
File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/db_upgrade.py", line 25, in db_upgrade
flask_migrate.upgrade(migration_folder)
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/flask_migrate/__init__.py", line 244, in upgrade
command.upgrade(config, revision, sql=sql, tag=tag)
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/command.py", line 254, in upgrade
script.run_env()
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/script/base.py", line 416, in run_env
util.load_python_file(self.dir, 'env.py')
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/util/pyfiles.py", line 93, in load_python_file
module = load_module_py(module_id, path)
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/util/compat.py", line 75, in load_module_py
mod = imp.load_source(module_id, path, fp)
File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/../../migrations/env.py", line 85, in <module>
run_migrations_online()
File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/../../migrations/env.py", line 78, in run_migrations_online
context.run_migrations()
File "<string>", line 8, in run_migrations
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/runtime/environment.py", line 817, in run_migrations
self.get_context().run_migrations(**kw)
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/runtime/migration.py", line 323, in run_migrations
step.migration_fn(**kw)
File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/migrations/versions/fdc58d9bd449_.py", line 84, in upgrade
email, password = user_info()
File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/user_info.py", line 50, in user_info
email = input("Email address: ")
File "<string>", line 1
^
SyntaxError: invalid syntax
On Fri, Mar 31, 2017 at 8:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA minor add-on patch for README.--Regards,On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
pgadmin-hackers by date: