Postgres Pro
Downloads
Home   >   mailing lists

"ALTER TRIGGER .. RENAME TO" broken with the "Remove WITH OIDS" commit. - Mailing list pgsql-hackers

From Rushabh Lathia
Subject "ALTER TRIGGER .. RENAME TO" broken with the "Remove WITH OIDS" commit.
Date
Msg-id CAGPqQf04PywZX3sVQaF6H=oLiW9GJncRW+=e78vTy4MokEWcZw@mail.gmail.com
Whole thread Raw
Responses Re: "ALTER TRIGGER .. RENAME TO" broken with the "Remove WITH OIDS"commit.
List pgsql-hackers
Tree view
Hi,

I found that ALTER TRIGGER .. RENAME TO is broken and it's
unable to rename the trigger.  Looking further seems renametrig()
function, copy the new trigger name into wrong tuple.  This is
broken with below commit:

commit 578b229718e8f15fa779e20f086c4b6bb3776106
Author: Andres Freund <andres@anarazel.de>
Date:   Tue Nov 20 15:36:57 2018 -0800

    Remove WITH OIDS support, change oid catalog column visibility.

PFA patch to fix the issue.  I also added the testcase for the
same into the regression.

regards,
Rushabh Lathia
www.EnterpriseDB.com

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: WIP: Avoid creation of the free space map for small tables
Next
From: Arthur Zakirov
Date:
Subject: Re: [PROPOSAL] Shared Ispell dictionaries