Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document - Mailing list pgsql-hackers

From shihao zhong
Subject Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
Date
Msg-id CAGRkXqTm7ym0Ds+V2QrxE543qqfx8=TXEF6Fk1bcuyDvc8iTqQ@mail.gmail.com
Whole thread Raw
In response to Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
List pgsql-hackers


On Tue, Oct 31, 2023 at 9:07 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
shihao zhong <zhong950419@gmail.com> writes:
> I noticed that the CREATE/ALTER TABLE document does not mention that
> EXCLUDE can accept a collation. I created a documentation fix for this
> issue, and I have attached it to this email.

> Hmm ... is this actually correct?  I think that the collate
> option has to come before the opclass name etc, so you'd need
> to shove it into exclude_element to provide an accurate
> description of the syntax.
>
>                         regards, tom lane
Hi Tom,
Thank you for your feedback on my previous patch. I have fixed the issue and attached a new patch for your review. Could you please take a look for it if you have a sec? Thanks

Also, if I understand correctly, the changes to sql_help.c will be made by the committer, so I do not need to run create_help.pl in my patch. Can you please confirm?

I appreciate your help and time.

Thanks,
Shihao
Attachment

pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: Re: Extract numeric filed in JSONB more effectively
Next
From: shihao zhong
Date:
Subject: Re: speed up a logical replica setup