Re: 'converts internal representation to "..."' comment is confusing - Mailing list pgsql-hackers

From Steve Chavez
Subject Re: 'converts internal representation to "..."' comment is confusing
Date
Msg-id CAGRrpzbBuQEGB7irJDpTegjdr29RpMKz-Kx0YocDdSRGAKDWJQ@mail.gmail.com
Whole thread Raw
In response to Re: 'converts internal representation to "..."' comment is confusing  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: 'converts internal representation to "..."' comment is confusing
List pgsql-hackers
Hello hackers,

Tom, could we apply this patch since Robert agrees it's an improvement?

Best regards,
Steve 

On Tue, 16 May 2023 at 07:49, Robert Haas <robertmhaas@gmail.com> wrote:
On Sun, May 14, 2023 at 9:37 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Steve Chavez <steve@supabase.io> writes:
> > I found "..." confusing in some comments, so this patch changes it to
> > "cstring". Which seems to be the intention after all.
>
> Those comments are Berkeley-era, making them probably a decade older
> than the "cstring" pseudotype (invented in b663f3443).  Perhaps what
> you suggest is an improvement, but I'm not sure that appealing to
> original intent can make the case.

FWIW, it does seem like an improvement to me.

--
Robert Haas
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: Re: Do we want a hashset type?
Next
From: Steve Chavez
Date:
Subject: Castable Domains for different JSON representations