Re: strange perf regression with data checksums - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: strange perf regression with data checksums
Date
Msg-id CAH2-Wzkfc70F0_2DxiepMUNLEDnnw-+-hYUVmpzGyJ6w+JnwxA@mail.gmail.com
Whole thread Raw
In response to Re: strange perf regression with data checksums  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: strange perf regression with data checksums
List pgsql-hackers
On Wed, Jun 4, 2025 at 10:21 AM Peter Geoghegan <pg@bowt.ie> wrote:
> On Wed, Jun 4, 2025 at 7:33 AM Tomas Vondra <tomas@vondra.me> wrote:
> > So better to get this in now, otherwise we may have to wait until PG19,
> > because of ABI (the patch adds a field into BTScanPosData, but maybe
> > it'd be possible to add it into padding, not sure).
>
> I agree. I can get this into shape for commit today.

Attached is v3, which is functionally the same as v2. It has improved
comments, and a couple of extra assertions. Plus there's a real commit
message now.

I also relocated the code that sets so.drop_pin from
_bt_preprocess_keys to btrescan. That seems like the more logical
place for it.

My current plan is to commit this in the next couple of days.

--
Peter Geoghegan

Attachment

pgsql-hackers by date:

Previous
From: Sami Imseih
Date:
Subject: Re: Improve explicit cursor handling in pg_stat_statements
Next
From: Masahiko Sawada
Date:
Subject: Re: Fix slot synchronization with two_phase decoding enabled