Re: ON CONFLICT DO UPDATE for partitioned tables - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: ON CONFLICT DO UPDATE for partitioned tables
Date
Msg-id CAH2-WzmPZUb68f4hvDGgZBKJ2KMdvaJRwwfYH=5EHUOrzKuK0w@mail.gmail.com
Whole thread Raw
In response to Re: ON CONFLICT DO UPDATE for partitioned tables  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thu, Apr 19, 2018 at 12:00 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Thu, Apr 19, 2018 at 1:20 PM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>> How about simply relaxing the tdtypeid test from equalTupleDescs?  I
>> haven't looked deeply but I think just checking whether or not both are
>> RECORDOID might be sufficient, for typecache purposes.
>
> That strike me as a very scary thing to do.  There's code all over the
> system that may have non-obvious assumptions about the behavior of
> equalTupleDescs(), and I don't think we can have any confidence that
> nothing will break unless we do a detailed audit of all that code.

+1. I think that it is plainly a bad idea to do something like that at
this point in the cycle.

-- 
Peter Geoghegan


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: initdb fails to initialize data directory
Next
From: Alvaro Herrera
Date:
Subject: Re: ON CONFLICT DO UPDATE for partitioned tables