Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows
Date
Msg-id CAH2-Wzn78Trk4URWLPudbpEkEMs=Nic+r6j6278ZNdjO+meWRA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows
List pgsql-hackers
Tree view 
On Fri, Sep 22, 2017 at 7:25 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> I agree.  The attached patch should do it.

I see one small issue here: You'll now need to set ssup->comparator
back to NULL before you return early in the Windows' libc case. That
way, a shim comparator (that goes through bttextcmp(), in the case of
text) will be installed within FinishSortSupportFunction(). Other than
that, looks good to me.

Thanks
-- 
Peter Geoghegan


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] 10RC1 crash testing MultiXact oddity
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] close_ps, NULLs, and DirectFunctionCall