Re: Add pg_get_injection_points() for information of injection points - Mailing list pgsql-hackers

From Rahila Syed
Subject Re: Add pg_get_injection_points() for information of injection points
Date
Msg-id CAH2L28sePmh4PET+AfWDicoV=N7w2gGnSAMsAJjiMD23NGatNg@mail.gmail.com
Whole thread Raw
In response to Re: Add pg_get_injection_points() for information of injection points  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi Michael,

 #include "miscadmin.h"
+#include "nodes/execnodes.h"
 #include "nodes/pg_list.h"
 #include "nodes/value.h"

Do we need to include this? I did not see any compilation error when I removed this.

 
Now for the second part with the SRF making the injection point
information available at SQL level.  The point about adding the new
function in the core engine has been sticky, and I'm coming down to
the conclusion that I'd still want to make this stuff backpatchable if
need be in the future.  So let's just add a new function in the test
module injection_points and call it a day.


Do you plan to document this function anywhere where it would be more visible to those
who might want to use it in their tests?
 
Thank you,
Rahila Syed

pgsql-hackers by date:

Previous
From: Shinya Kato
Date:
Subject: Re: Extend COPY FROM with HEADER to skip multiple lines
Next
From: Shlok Kyal
Date:
Subject: Re: stats.sql might fail due to shared buffers also used by parallel tests