Re: analyze-in-stages post upgrade questions - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: analyze-in-stages post upgrade questions
Date
Msg-id CAHGQGwGje3mv5sOmyCJ0NroNPF8938OYCOHMJZbegTekccZZ=g@mail.gmail.com
Whole thread Raw
In response to Re: analyze-in-stages post upgrade questions  (Laurenz Albe <laurenz.albe@cybertec.at>)
Responses Re: analyze-in-stages post upgrade questions
List pgsql-hackers
On Thu, Aug 7, 2025 at 5:52 AM Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> > I understand your point. But on second thought, since the patch changes
> > behavior, I'm leaning toward treating it as an improvement, so it should
> > only go to master...
>
> I agree that this behavior change should not be backpatched.
> That is not a bugfix.

+1

> > --------------------
> > vacuumdb should generally follow the behavior of the underlying
> > VACUUM and ANALYZE commands. If analyze_only is true, process
> > regular tables, materialized views, and partitioned tables, just like
> > ANALYZE (with no specific target tables) does. Otherwise, process
> > only regular tables and materialized views, since VACUUM skips
> > partitioned tables when no target tables are specified.
> > --------------------
>
> I am fine with that suggestion.

Thanks! So I've updated the patch based on my earlier comments.
Unless there are objections, I'll commit the attached version to master only.

Regards,

--
Fujii Masao

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: analyze-in-stages post upgrade questions
Next
From: Chao Li
Date:
Subject: Re: Improve hash join's handling of tuples with null join keys