Re: [PATCH] Include application_name in "connection authorized" log message - Mailing list pgsql-hackers

From Don Seiler
Subject Re: [PATCH] Include application_name in "connection authorized" log message
Date
Msg-id CAHJZqBAC_HWNx2G39FTZQ=X-Sk0oE59rOt+tHszR401KenHpjw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Include application_name in "connection authorized" logmessage  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [PATCH] Include application_name in "connection authorized" logmessage
List pgsql-hackers
On Mon, Jul 30, 2018 at 5:20 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
On 13/07/2018 20:20, Don Seiler wrote:
> See attached for latest revision.

This doesn't compile with SSL enabled because there is a comma missing.

Hmm I'll check this out tonight. Sorry I wasn't able to get to this until now.
 
This implementation doesn't run the application_name through
check_application_name(), so it could end up logging application_name
values that are otherwise not acceptable.  I'm not sure of the best way
to fix that.

Is the concern that any user can set their client's application name value to any string they want? Is there a reason we can't call check_application_name() before setting it in the Port struct in postmaster.c?

Don.

--
Don Seiler
www.seiler.us

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: ATTACH/DETACH PARTITION CONCURRENTLY
Next
From: Alexander Kuzmenkov
Date:
Subject: Re: Reopen logfile on SIGHUP