On Sun, Apr 6, 2025 at 2:42 PM Tender Wang <tndrwang@gmail.com> wrote: > Daniel Gustafsson <daniel@yesql.se> 于2025年4月6日周日 19:23写道： >> >> > On 6 Apr 2025, at 06:02, Tender Wang <tndrwang@gmail.com> wrote: >> >> > I find that the postgresql.conf.sample file doesn't contain enable_self_join_elimination guc. >> > If this is necessary, please see the attached patch. >> >> The GUC is marked as not supposed by the in the sample file, either it really >> shouldn't or that needs to be removed from the GUC declaration. > > > Sorry, I didn't see the GUC_NOT_IN_SAMPLE flag. Thanks for the reminder. > Please ignore the noise.
Also, sorry for thoughtless commit of that. Nevertheless, should we consider revisiting this flag? I see the only other GUC simultaneously QUERY_TUNING_METHOD and GUC_NOT_IN_SAMPLE is optimize_bounded_sort, which is not exposed in a standard build.
Agree.
Putting enable_self_join_elimination into sample file seems a good choice.
