Re: Logical Replication of sequences - Mailing list pgsql-hackers

Hi Vignesh.

Review comments for patch v20250422-0001.

======
Commit message

1.
This patch introduces a new function: pg_sequence_state function
allows retrieval of sequence values including LSN.

SUGGESTION
This patch introduces a new function, 'pg_sequence_state', which
allows retrieval of sequence values, including the associated LSN.

======
src/backend/commands/sequence.c

pg_sequence_state:

2.
+ ereport(ERROR,
+ (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
+ errmsg("permission denied for sequence %s",
+ RelationGetRelationName(seqrel))));

Has redundant parentheses.

======
Kind Regards,
Peter Smith.
Fujitsu Australia