Hi,
I saw a sequence replication patch was committed recently [1], so I
was looking at the diffs. Below are a couple of observations:
//////////
1.
The following message seems overly long:
errmsg("publication parameters are not applicable to sequence
synchronization and will be ignored for sequences"));
I saw the message was already discussed here [2], but at that time, it
was not shortened much.
How about something shorter? Some examples.
errmsg("publication parameters will be ignored for sequences"));
errmsg("publication parameters will be ignored for sequence replication"));
======
2.
+-- Specifying WITH clause in an ALL SEQUENCES publication will emit a NOTICE.
+SET client_min_messages = 'NOTICE';
+CREATE PUBLICATION regress_pub_for_allsequences_alltables_withclause
FOR ALL SEQUENCES, ALL TABLES WITH (publish = 'insert');
+CREATE PUBLICATION regress_pub_for_allsequences_withclause FOR ALL
SEQUENCES WITH (publish_generated_columns = 'stored');
+RESET client_min_messages;
Why not also test WITH('publish_via_partition_root')?
======
[1] https://github.com/postgres/postgres/commit/96b37849734673e7c82fb86c4f0a46a28f500ac8
[2] https://www.postgresql.org/message-id/CAA4eK1L3SdsMFB6KZ6qEU05wUDtoKS%2BOsvo9UoGP--qVz2PBrg%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
