Hi Maxime,
> > Can you think of any test cases we can add to the code base?
>
> The only idea I have would be adding a new index module in src/test/modules that has this particular property and
havea test that will hit get_actual_variable_range().
> For example, it could be a new access method that is a copy of btree, but whose amcanreturn property is null and that
specificallysets scan->xs_itup to null in amgettuple.
>
> Without the patch, such a test would fail with 'ERROR: no data returned for index-only scan’, while with the patch it
wouldpass.
Yes, this is how we typically test cases like this. IMO adding a test
module would be helpful. It can be reused for other scenarios.
--
Best regards,
Aleksander Alekseev
