Re: encode/decode support for base64url - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: encode/decode support for base64url
Date
Msg-id CAJ7c6TOG4SuVGd2L17A7qjLx0ReqoXs9DZVAeHtQtytkk-b7=g@mail.gmail.com
Whole thread Raw
In response to Re: encode/decode support for base64url  (Florents Tselai <florents.tselai@gmail.com>)
Responses Re: encode/decode support for base64url
List pgsql-hackers
Hi Florents,

Thanks for the update!

> here's a v4 patch set
>
> - Extracted pg_base64_{en,de}_internal with an  additional bool url param, to be used by other functions
> - Added a few more test cases
>
> Cary mentioned above
>
> > In addition, you may also want to add the C versions of base64rul encode
> and decode functions to "src/common/base64.c" as new API calls
>
> Haven't done that, but I could;
> Although I think it'd probably be best to do it in a separate patch.

I reviewed and tested v4. To me it looks as good as it will get.
Personally I would change a few minor things here and there and
probably merge all three patches into a single commit. This however is
up to the committer to decide.

Changing the CF entry status to "RfC".



pgsql-hackers by date:

Previous
From: Frédéric Yhuel
Date:
Subject: Re: [doc] minor fix for CREATE INDEX CONCURRENTLY
Next
From: Hannu Krosing
Date:
Subject: Re: Horribly slow pg_upgrade performance with many Large Objects