Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin - Mailing list pgadmin-hackers

On Thu, Feb 2, 2017 at 6:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Hi,

Currently Ashesh is working  for the particular issue on my machine and he will share the updated patch on tomorrow.

Thanks Fahar for your help to figure out the actual issue.

Please find the updated patch.

I've added logging functionality in the process executor permanently.

Working as expected with the latest patch on my systems (OSX, and Window 10).

 

--

Thanks & Regards,

Ashesh Vashi

Kind Regards,

On Thu, Feb 2, 2017 at 11:22 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Sure Ashesh,

I will test and update the testing status accordingly.

On Thu, Feb 2, 2017 at 11:17 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Fahar,

Can you please test the updated patch?

I have fixed one issue on windows, and also added logging information in the background process execution for future issue analysis.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Jan 23, 2017 at 12:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Hi Murtaza,

I am using Administrator user on 2012 server . Can you please check this behavior on my machine through skype or google talk?

Regards,

On Mon, Jan 23, 2017 at 10:07 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected, 

I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator?

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Jan 21, 2017 at 1:18 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created  displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Fahar,

Could you please test this updated patch?

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:

Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:

Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:

{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.

Please find the updated patch.

Changes:

- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.

- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company