Home > mailing lists

Thread: [pgadmin-hackers] PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

[pgadmin-hackers] PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Ashesh Vashi

Date:

09 December 2016, 12:16:23

Hi Dave,

Please find the patch to resolve the issue reported in RM #1679

This will take care of:

- Find the appropriate available Python interpreter to execute the process_executor.py.

In case of WSGI or Runtime, it was not properly find the interpreter required to execute that script. Also, on windows - we should give priority to the windowless python interpreter (if available).

- Execute the process_executor.py script with proper platform dependent flags to run it as daemon.

- Run the process_executor.py in proper daemon mode. It helps to run the long running processes like backup, restore, etc.

On windows, run the process_executor.py from process_executor.py in detached mode to allow the child process to run in detached mode.

On POSIX, fork the process_executor.py to allow the child process to run in daemon mode.

Also - listen the signal like SIGINT, SIGTERM, so that - the child does not kill, or hangup (It used to happen.

NOTE:

This patch does not take care of the unicode errors in the path. I will send a separate patch for the same.

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

Attachment

RM1679_v2.patch

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Dave Page

Date:

12 December 2016, 13:31:06

Hi,

On Fri, Dec 9, 2016 at 9:16 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Dave,

Please find the patch to resolve the issue reported in RM #1679

This will take care of:
- Find the appropriate available Python interpreter to execute the process_executor.py.
In case of WSGI or Runtime, it was not properly find the interpreter required to execute that script. Also, on windows - we should give priority to the windowless python interpreter (if available).
- Execute the process_executor.py script with proper platform dependent flags to run it as daemon.
- Run the process_executor.py in proper daemon mode. It helps to run the long running processes like backup, restore, etc.
On windows, run the process_executor.py from process_executor.py in detached mode to allow the child process to run in detached mode.
On POSIX, fork the process_executor.py to allow the child process to run in daemon mode.
Also - listen the signal like SIGINT, SIGTERM, so that - the child does not kill, or hangup (It used to happen.

NOTE:
This patch does not take care of the unicode errors in the path. I will send a separate patch for the same.

Unfortunately my first test of this failed:

SERVER_MODE = False

Python 2.7.11 (Mac default)

Running in Chrome

I ran a backup of a database, and got the green backup initiated popup... then, nothing. Upon checking my config, I found I had the PostgreSQL Bin Path set to "$DIR/a/b/c", which clearly won't work. So, we're not yet detecting failure to start a process properly.

I then corrected the path to "/Library/PostgreSQL/9.6/bin", and re-ran the backup. That didn't work either - I saw exactly the same result as before, a green popup, then nothing.

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Ashesh Vashi

Date:

16 December 2016, 13:16:18

Hi Dave,

On Mon, Dec 12, 2016 at 4:01 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi,

On Fri, Dec 9, 2016 at 9:16 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

Please find the patch to resolve the issue reported in RM #1679

This will take care of:
- Find the appropriate available Python interpreter to execute the process_executor.py.
In case of WSGI or Runtime, it was not properly find the interpreter required to execute that script. Also, on windows - we should give priority to the windowless python interpreter (if available).
- Execute the process_executor.py script with proper platform dependent flags to run it as daemon.
- Run the process_executor.py in proper daemon mode. It helps to run the long running processes like backup, restore, etc.
On windows, run the process_executor.py from process_executor.py in detached mode to allow the child process to run in detached mode.
On POSIX, fork the process_executor.py to allow the child process to run in daemon mode.
Also - listen the signal like SIGINT, SIGTERM, so that - the child does not kill, or hangup (It used to happen.

NOTE:
This patch does not take care of the unicode errors in the path. I will send a separate patch for the same.

Unfortunately my first test of this failed:

SERVER_MODE = False
Python 2.7.11 (Mac default)
Running in Chrome

I ran a backup of a database, and got the green backup initiated popup... then, nothing. Upon checking my config, I found I had the PostgreSQL Bin Path set to "$DIR/a/b/c", which clearly won't work. So, we're not yet detecting failure to start a process properly.

During exception handling, the logger's encoding was not set properly during initialisation, that was resulting into an error.

Also - sometime the process execution does not start quickly enough to list down the process execution properly.

Hence - we should check the process list after some time.

Please find the update patch with the above both problems resolved.

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

I then corrected the path to "/Library/PostgreSQL/9.6/bin", and re-ran the backup. That didn't work either - I saw exactly the same result as before, a green popup, then nothing.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

RM1679_v4.patch

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Dave Page

Date:

19 December 2016, 14:52:19

On Fri, Dec 16, 2016 at 10:16 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Dave,

On Mon, Dec 12, 2016 at 4:01 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi,

On Fri, Dec 9, 2016 at 9:16 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

Please find the patch to resolve the issue reported in RM #1679

This will take care of:
- Find the appropriate available Python interpreter to execute the process_executor.py.
In case of WSGI or Runtime, it was not properly find the interpreter required to execute that script. Also, on windows - we should give priority to the windowless python interpreter (if available).
- Execute the process_executor.py script with proper platform dependent flags to run it as daemon.
- Run the process_executor.py in proper daemon mode. It helps to run the long running processes like backup, restore, etc.
On windows, run the process_executor.py from process_executor.py in detached mode to allow the child process to run in detached mode.
On POSIX, fork the process_executor.py to allow the child process to run in daemon mode.
Also - listen the signal like SIGINT, SIGTERM, so that - the child does not kill, or hangup (It used to happen.

NOTE:
This patch does not take care of the unicode errors in the path. I will send a separate patch for the same.

Unfortunately my first test of this failed:

SERVER_MODE = False
Python 2.7.11 (Mac default)
Running in Chrome

I ran a backup of a database, and got the green backup initiated popup... then, nothing. Upon checking my config, I found I had the PostgreSQL Bin Path set to "$DIR/a/b/c", which clearly won't work. So, we're not yet detecting failure to start a process properly.
During exception handling, the logger's encoding was not set properly during initialisation, that was resulting into an error.

Also - sometime the process execution does not start quickly enough to list down the process execution properly.
Hence - we should check the process list after some time.

Please find the update patch with the above both problems resolved.

Same results with the new patch - either with a correct bin path or an incorrect one, I see the green notification that the backup has started, then nothing.

Sidenote: I don't even see anything at all in the console output. I think we should at least spit out a debug message showing the command line we're executing the launcher with, and ideally include any other details we can such as job IDs etc.

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Dave Page

Date:

19 December 2016, 14:58:20

On Mon, Dec 19, 2016 at 11:52 AM, Dave Page <dpage@pgadmin.org> wrote:
>
>
> On Fri, Dec 16, 2016 at 10:16 AM, Ashesh Vashi
> <ashesh.vashi@enterprisedb.com> wrote:
>>
>> Hi Dave,
>>
>> On Mon, Dec 12, 2016 at 4:01 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi,
>>>
>>> On Fri, Dec 9, 2016 at 9:16 AM, Ashesh Vashi
>>> <ashesh.vashi@enterprisedb.com> wrote:
>>>>
>>>> Hi Dave,
>>>>
>>>> Please find the patch to resolve the issue reported in RM #1679
>>>>
>>>> This will take care of:
>>>> - Find the appropriate available Python interpreter to execute the
>>>> process_executor.py.
>>>>   In case of WSGI or Runtime, it was not properly find the interpreter
>>>> required to execute that script. Also, on windows - we should give priority
>>>> to the windowless python interpreter (if available).
>>>> - Execute the process_executor.py script with proper platform dependent
>>>> flags to run it as daemon.
>>>> - Run the process_executor.py in proper daemon mode. It helps to run the
>>>> long running processes like backup, restore, etc.
>>>>   On windows, run the process_executor.py from process_executor.py in
>>>> detached mode to allow the child process to run in detached mode.
>>>>   On POSIX, fork the process_executor.py to allow the child process to
>>>> run in daemon mode.
>>>>   Also - listen the signal like SIGINT, SIGTERM, so that - the child
>>>> does not kill, or hangup (It used to happen.
>>>>
>>>>
>>>> NOTE:
>>>> This patch does not take care of the unicode errors in the path. I will
>>>> send a separate patch for the same.
>>>
>>>
>>> Unfortunately my first test of this failed:
>>>
>>> SERVER_MODE = False
>>> Python 2.7.11 (Mac default)
>>> Running in Chrome
>>>
>>> I ran a backup of a database, and got the green backup initiated popup...
>>> then, nothing. Upon checking my config, I found I had the PostgreSQL Bin
>>> Path set to "$DIR/a/b/c", which clearly won't work. So, we're not yet
>>> detecting failure to start a process properly.
>>
>> During exception handling, the logger's encoding was not set properly
>> during initialisation,  that was resulting into an error.
>>
>> Also - sometime the process execution does not start quickly enough to
>> list down the process execution properly.
>> Hence - we should check the process list after some time.
>>
>> Please find the update patch with the above both problems resolved.
>
>
> Same results with the new patch - either with a correct bin path or an
> incorrect one, I see the green notification that the backup has started,
> then nothing.
>
> Sidenote: I don't even see anything at all in the console output. I think we
> should at least spit out a debug message showing the command line we're
> executing the launcher with, and ideally include any other details we can
> such as job IDs etc.

BTW; attached is my process table from the SQLite database.

I believe the last two rows are from my test today. The out and err
logs for both are empty files.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

process.csv

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Ashesh Vashi

Date:

10 January 2017, 15:17:29

Hi Team,

In new implementation - we are forking the process-executor on the POSIX system to run the process in true daemon mode.

And, we were updating the status in the configuration file (which is sqlite database), it was crashing while opening the configuration file, and couldn't update the status.

Reference: https://bugs.python.org/issue27126

In order to resolve the issue, we're now creating a 'status' file for the process information.

And, it will be used to check the status information about the process.

Thanks Dave for helping find out the root cause of the issue, and point out the correct reference point.

Please find the updated patch with the latest changes.

I have also attached a patch to make the restore, and backup routes more REST API compatible.

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Dec 19, 2016 at 5:28 PM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Dec 19, 2016 at 11:52 AM, Dave Page <dpage@pgadmin.org> wrote:
>
>
> On Fri, Dec 16, 2016 at 10:16 AM, Ashesh Vashi
> <ashesh.vashi@enterprisedb.com> wrote:
>>
>> Hi Dave,
>>
>> On Mon, Dec 12, 2016 at 4:01 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi,
>>>
>>> On Fri, Dec 9, 2016 at 9:16 AM, Ashesh Vashi
>>> <ashesh.vashi@enterprisedb.com> wrote:
>>>>
>>>> Hi Dave,
>>>>
>>>> Please find the patch to resolve the issue reported in RM #1679
>>>>
>>>> This will take care of:
>>>> - Find the appropriate available Python interpreter to execute the
>>>> process_executor.py.
>>>> In case of WSGI or Runtime, it was not properly find the interpreter
>>>> required to execute that script. Also, on windows - we should give priority
>>>> to the windowless python interpreter (if available).
>>>> - Execute the process_executor.py script with proper platform dependent
>>>> flags to run it as daemon.
>>>> - Run the process_executor.py in proper daemon mode. It helps to run the
>>>> long running processes like backup, restore, etc.
>>>> On windows, run the process_executor.py from process_executor.py in
>>>> detached mode to allow the child process to run in detached mode.
>>>> On POSIX, fork the process_executor.py to allow the child process to
>>>> run in daemon mode.
>>>> Also - listen the signal like SIGINT, SIGTERM, so that - the child
>>>> does not kill, or hangup (It used to happen.
>>>>
>>>>
>>>> NOTE:
>>>> This patch does not take care of the unicode errors in the path. I will
>>>> send a separate patch for the same.
>>>
>>>
>>> Unfortunately my first test of this failed:
>>>
>>> SERVER_MODE = False
>>> Python 2.7.11 (Mac default)
>>> Running in Chrome
>>>
>>> I ran a backup of a database, and got the green backup initiated popup...
>>> then, nothing. Upon checking my config, I found I had the PostgreSQL Bin
>>> Path set to "$DIR/a/b/c", which clearly won't work. So, we're not yet
>>> detecting failure to start a process properly.
>>
>> During exception handling, the logger's encoding was not set properly
>> during initialisation, that was resulting into an error.
>>
>> Also - sometime the process execution does not start quickly enough to
>> list down the process execution properly.
>> Hence - we should check the process list after some time.
>>
>> Please find the update patch with the above both problems resolved.
>
>
> Same results with the new patch - either with a correct bin path or an
> incorrect one, I see the green notification that the backup has started,
> then nothing.
>
> Sidenote: I don't even see anything at all in the console output. I think we
> should at least spit out a debug message showing the command line we're
> executing the launcher with, and ideally include any other details we can
> such as job IDs etc.

BTW; attached is my process table from the SQLite database.

I believe the last two rows are from my test today. The out and err
logs for both are empty files.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Dave Page

Date:

11 January 2017, 09:33:03

Attempting a backup with an incorrect bin path worked as expected with this version, but once I corrected the path and started another backup, I got the following:

2017-01-11 11:45:22,627: INFO werkzeug: 127.0.0.1 - - [11/Jan/2017 11:45:22] "GET /misc/bgprocess/?_=1484115208342 HTTP/1.1" 500 -

Traceback (most recent call last):

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1994, in __call__

return self.wsgi_app(environ, start_response)

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1985, in wsgi_app

response = self.handle_exception(e)

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1540, in handle_exception

reraise(exc_type, exc_value, tb)

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app

response = self.full_dispatch_request()

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request

rv = self.handle_user_exception(e)

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception

reraise(exc_type, exc_value, tb)

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request

rv = self.dispatch_request()

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request

return self.view_functions[rule.endpoint](**req.view_args)

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask_login.py", line 792, in decorated_view

return func(*args, **kwargs)

File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/__init__.py", line 70, in index

return make_response(response=BatchProcess.list())

File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/processes.py", line 410, in list

status, updated = BatchProcess.update_process_info(p)

File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/processes.py", line 393, in update_process_info

except json.JSONDecodeError as e:

AttributeError: 'module' object has no attribute 'JSONDecodeError'

I fixed that by adding:

try:

JSONDecodeError = json.JSONDecodeError

except AttributeError:

JSONDecodeError = ValueError

at line 380 of processes.py, then updating the exception handler accordingly.

I then tried to backup an entire server, and got:

2017-01-11 11:57:21,841: INFO werkzeug: 127.0.0.1 - - [11/Jan/2017 11:57:21] "GET /misc/bgprocess/?_=1484115967417 HTTP/1.1" 500 -

Traceback (most recent call last):

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1994, in __call__

return self.wsgi_app(environ, start_response)

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1985, in wsgi_app

response = self.handle_exception(e)

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1540, in handle_exception

reraise(exc_type, exc_value, tb)

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app

response = self.full_dispatch_request()

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request

rv = self.handle_user_exception(e)

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception

reraise(exc_type, exc_value, tb)

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request

rv = self.dispatch_request()

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request

return self.view_functions[rule.endpoint](**req.view_args)

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask_login.py", line 792, in decorated_view

return func(*args, **kwargs)

File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/__init__.py", line 70, in index

return make_response(response=BatchProcess.list())

File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/processes.py", line 415, in list

status, updated = BatchProcess.update_process_info(p)

File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/processes.py", line 390, in update_process_info

if data['end_time']:

KeyError: u'end_time'

The status file contains:

{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

On Tue, Jan 10, 2017 at 5:47 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Team,

In new implementation - we are forking the process-executor on the POSIX system to run the process in true daemon mode.
And, we were updating the status in the configuration file (which is sqlite database), it was crashing while opening the configuration file, and couldn't update the status.
Reference: https://bugs.python.org/issue27126

In order to resolve the issue, we're now creating a 'status' file for the process information.
And, it will be used to check the status information about the process.

Thanks Dave for helping find out the root cause of the issue, and point out the correct reference point.
Please find the updated patch with the latest changes.

I have also attached a patch to make the restore, and backup routes more REST API compatible.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Dec 19, 2016 at 5:28 PM, Dave Page <dpage@pgadmin.org> wrote:
On Mon, Dec 19, 2016 at 11:52 AM, Dave Page <dpage@pgadmin.org> wrote:
>
>
> On Fri, Dec 16, 2016 at 10:16 AM, Ashesh Vashi
> <ashesh.vashi@enterprisedb.com> wrote:
>>
>> Hi Dave,
>>
>> On Mon, Dec 12, 2016 at 4:01 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi,
>>>
>>> On Fri, Dec 9, 2016 at 9:16 AM, Ashesh Vashi
>>> <ashesh.vashi@enterprisedb.com> wrote:
>>>>
>>>> Hi Dave,
>>>>
>>>> Please find the patch to resolve the issue reported in RM #1679
>>>>
>>>> This will take care of:
>>>> - Find the appropriate available Python interpreter to execute the
>>>> process_executor.py.
>>>> In case of WSGI or Runtime, it was not properly find the interpreter
>>>> required to execute that script. Also, on windows - we should give priority
>>>> to the windowless python interpreter (if available).
>>>> - Execute the process_executor.py script with proper platform dependent
>>>> flags to run it as daemon.
>>>> - Run the process_executor.py in proper daemon mode. It helps to run the
>>>> long running processes like backup, restore, etc.
>>>> On windows, run the process_executor.py from process_executor.py in
>>>> detached mode to allow the child process to run in detached mode.
>>>> On POSIX, fork the process_executor.py to allow the child process to
>>>> run in daemon mode.
>>>> Also - listen the signal like SIGINT, SIGTERM, so that - the child
>>>> does not kill, or hangup (It used to happen.
>>>>
>>>>
>>>> NOTE:
>>>> This patch does not take care of the unicode errors in the path. I will
>>>> send a separate patch for the same.
>>>
>>>
>>> Unfortunately my first test of this failed:
>>>
>>> SERVER_MODE = False
>>> Python 2.7.11 (Mac default)
>>> Running in Chrome
>>>
>>> I ran a backup of a database, and got the green backup initiated popup...
>>> then, nothing. Upon checking my config, I found I had the PostgreSQL Bin
>>> Path set to "$DIR/a/b/c", which clearly won't work. So, we're not yet
>>> detecting failure to start a process properly.
>>
>> During exception handling, the logger's encoding was not set properly
>> during initialisation, that was resulting into an error.
>>
>> Also - sometime the process execution does not start quickly enough to
>> list down the process execution properly.
>> Hence - we should check the process list after some time.
>>
>> Please find the update patch with the above both problems resolved.
>
>
> Same results with the new patch - either with a correct bin path or an
> incorrect one, I see the green notification that the backup has started,
> then nothing.
>
> Sidenote: I don't even see anything at all in the console output. I think we
> should at least spit out a debug message showing the command line we're
> executing the launcher with, and ideally include any other details we can
> such as job IDs etc.

BTW; attached is my process table from the SQLite database.

I believe the last two rows are from my test today. The out and err
logs for both are empty files.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Ashesh Vashi

Date:

11 January 2017, 09:58:36

Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

Attempting a backup with an incorrect bin path worked as expected with this version, but once I corrected the path and started another backup, I got the following:

2017-01-11 11:45:22,627: INFO werkzeug: 127.0.0.1 - - [11/Jan/2017 11:45:22] "GET /misc/bgprocess/?_=1484115208342 HTTP/1.1" 500 -
Traceback (most recent call last):
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1994, in __call__
return self.wsgi_app(environ, start_response)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1985, in wsgi_app
response = self.handle_exception(e)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1540, in handle_exception
reraise(exc_type, exc_value, tb)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask_login.py", line 792, in decorated_view
return func(*args, **kwargs)
File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/__init__.py", line 70, in index
return make_response(response=BatchProcess.list())
File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/processes.py", line 410, in list
status, updated = BatchProcess.update_process_info(p)
File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/processes.py", line 393, in update_process_info
except json.JSONDecodeError as e:
AttributeError: 'module' object has no attribute 'JSONDecodeError'

I fixed that by adding:

try:
JSONDecodeError = json.JSONDecodeError
except AttributeError:
JSONDecodeError = ValueError

at line 380 of processes.py, then updating the exception handler accordingly.

I then tried to backup an entire server, and got:

2017-01-11 11:57:21,841: INFO werkzeug: 127.0.0.1 - - [11/Jan/2017 11:57:21] "GET /misc/bgprocess/?_=1484115967417 HTTP/1.1" 500 -
Traceback (most recent call last):
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1994, in __call__
return self.wsgi_app(environ, start_response)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1985, in wsgi_app
response = self.handle_exception(e)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1540, in handle_exception
reraise(exc_type, exc_value, tb)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask_login.py", line 792, in decorated_view
return func(*args, **kwargs)
File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/__init__.py", line 70, in index
return make_response(response=BatchProcess.list())
File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/processes.py", line 415, in list
status, updated = BatchProcess.update_process_info(p)
File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/processes.py", line 390, in update_process_info
if data['end_time']:
KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.

Please find the updated patch.

Changes:

- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.

- Checking the existence of value in dict before accessing it.

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Tue, Jan 10, 2017 at 5:47 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Team,

In new implementation - we are forking the process-executor on the POSIX system to run the process in true daemon mode.
And, we were updating the status in the configuration file (which is sqlite database), it was crashing while opening the configuration file, and couldn't update the status.
Reference: https://bugs.python.org/issue27126

In order to resolve the issue, we're now creating a 'status' file for the process information.
And, it will be used to check the status information about the process.

Thanks Dave for helping find out the root cause of the issue, and point out the correct reference point.
Please find the updated patch with the latest changes.

I have also attached a patch to make the restore, and backup routes more REST API compatible.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Dec 19, 2016 at 5:28 PM, Dave Page <dpage@pgadmin.org> wrote:
On Mon, Dec 19, 2016 at 11:52 AM, Dave Page <dpage@pgadmin.org> wrote:
>
>
> On Fri, Dec 16, 2016 at 10:16 AM, Ashesh Vashi
> <ashesh.vashi@enterprisedb.com> wrote:
>>
>> Hi Dave,
>>
>> On Mon, Dec 12, 2016 at 4:01 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi,
>>>
>>> On Fri, Dec 9, 2016 at 9:16 AM, Ashesh Vashi
>>> <ashesh.vashi@enterprisedb.com> wrote:
>>>>
>>>> Hi Dave,
>>>>
>>>> Please find the patch to resolve the issue reported in RM #1679
>>>>
>>>> This will take care of:
>>>> - Find the appropriate available Python interpreter to execute the
>>>> process_executor.py.
>>>> In case of WSGI or Runtime, it was not properly find the interpreter
>>>> required to execute that script. Also, on windows - we should give priority
>>>> to the windowless python interpreter (if available).
>>>> - Execute the process_executor.py script with proper platform dependent
>>>> flags to run it as daemon.
>>>> - Run the process_executor.py in proper daemon mode. It helps to run the
>>>> long running processes like backup, restore, etc.
>>>> On windows, run the process_executor.py from process_executor.py in
>>>> detached mode to allow the child process to run in detached mode.
>>>> On POSIX, fork the process_executor.py to allow the child process to
>>>> run in daemon mode.
>>>> Also - listen the signal like SIGINT, SIGTERM, so that - the child
>>>> does not kill, or hangup (It used to happen.
>>>>
>>>>
>>>> NOTE:
>>>> This patch does not take care of the unicode errors in the path. I will
>>>> send a separate patch for the same.
>>>
>>>
>>> Unfortunately my first test of this failed:
>>>
>>> SERVER_MODE = False
>>> Python 2.7.11 (Mac default)
>>> Running in Chrome
>>>
>>> I ran a backup of a database, and got the green backup initiated popup...
>>> then, nothing. Upon checking my config, I found I had the PostgreSQL Bin
>>> Path set to "$DIR/a/b/c", which clearly won't work. So, we're not yet
>>> detecting failure to start a process properly.
>>
>> During exception handling, the logger's encoding was not set properly
>> during initialisation, that was resulting into an error.
>>
>> Also - sometime the process execution does not start quickly enough to
>> list down the process execution properly.
>> Hence - we should check the process list after some time.
>>
>> Please find the update patch with the above both problems resolved.
>
>
> Same results with the new patch - either with a correct bin path or an
> incorrect one, I see the green notification that the backup has started,
> then nothing.
>
> Sidenote: I don't even see anything at all in the console output. I think we
> should at least spit out a debug message showing the command line we're
> executing the launcher with, and ideally include any other details we can
> such as job IDs etc.

BTW; attached is my process table from the SQLite database.

I believe the last two rows are from my test today. The out and err
logs for both are empty files.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

RM1679_v7.patch

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Dave Page

Date:

11 January 2017, 16:19:43

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

RM1679_v7.patch

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Fahar Abbas

Date:

12 January 2017, 08:47:13

Sure Dave,

Will test this after applying the patch today and update the status accordingly.

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Syed Fahar Abbas

Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

From

Fahar Abbas

Date:

17 January 2017, 12:44:49

Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Syed Fahar Abbas

Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Attachment

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Dave Page

Date:

17 January 2017, 12:46:10

Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Fahar Abbas

Date:

17 January 2017, 13:02:30

Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Syed Fahar Abbas

Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Dave Page

Date:

17 January 2017, 13:07:37

Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reportingstatus back to pgAdmin

From

Fahar Abbas

Date:

17 January 2017, 13:15:20

Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:

Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Syed Fahar Abbas

Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Murtuza Zabuawala

Date:

20 January 2017, 15:35:42

Hi Fahar,

Could you please test this updated patch?

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Attachment

RM1679_v8.patch

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Fahar Abbas

Date:

20 January 2017, 15:41:47

Sure Will test this on Monday will be leaving in few minutes.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Syed Fahar Abbas

Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

From

Fahar Abbas

Date:

20 January 2017, 16:31:41

Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Syed Fahar Abbas

Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Attachment

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Murtuza Zabuawala

Date:

20 January 2017, 16:49:43

That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Fahar Abbas

Date:

20 January 2017, 22:48:53

I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Syed Fahar Abbas

Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Murtuza Zabuawala

Date:

23 January 2017, 08:07:23

I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected,

I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator?

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Jan 21, 2017 at 1:18 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Fahar Abbas

Date:

23 January 2017, 09:49:32

Hi Murtaza,

I am using Administrator user on 2012 server . Can you please check this behavior on my machine through skype or google talk?

Regards,

On Mon, Jan 23, 2017 at 10:07 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected,

I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Jan 21, 2017 at 1:18 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Syed Fahar Abbas

Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Ashesh Vashi

Date:

02 February 2017, 09:17:49

Hi Fahar,

Can you please test the updated patch?

I have fixed one issue on windows, and also added logging information in the background process execution for future issue analysis.

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Jan 23, 2017 at 12:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Hi Murtaza,

I am using Administrator user on 2012 server . Can you please check this behavior on my machine through skype or google talk?

Regards,

On Mon, Jan 23, 2017 at 10:07 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected,

I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Jan 21, 2017 at 1:18 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Attachment

RM1679_v9.patch

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Fahar Abbas

Date:

02 February 2017, 09:22:49

Sure Ashesh,

I will test and update the testing status accordingly.

On Thu, Feb 2, 2017 at 11:17 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Fahar,

Can you please test the updated patch?
I have fixed one issue on windows, and also added logging information in the background process execution for future issue analysis.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Jan 23, 2017 at 12:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I am using Administrator user on 2012 server . Can you please check this behavior on my machine through skype or google talk?

Regards,

On Mon, Jan 23, 2017 at 10:07 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected,

I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Jan 21, 2017 at 1:18 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Syed Fahar Abbas

Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Fahar Abbas

Date:

02 February 2017, 15:49:01

Hi,

Currently Ashesh is working for the particular issue on my machine and he will share the updated patch on tomorrow.

Kind Regards,

On Thu, Feb 2, 2017 at 11:22 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Sure Ashesh,

I will test and update the testing status accordingly.

On Thu, Feb 2, 2017 at 11:17 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Fahar,

Can you please test the updated patch?
I have fixed one issue on windows, and also added logging information in the background process execution for future issue analysis.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Jan 23, 2017 at 12:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I am using Administrator user on 2012 server . Can you please check this behavior on my machine through skype or google talk?

Regards,

On Mon, Jan 23, 2017 at 10:07 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected,

I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Jan 21, 2017 at 1:18 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Syed Fahar Abbas

Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Ashesh Vashi

Date:

02 February 2017, 19:14:40

On Thu, Feb 2, 2017 at 6:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Hi,

Currently Ashesh is working for the particular issue on my machine and he will share the updated patch on tomorrow.

Thanks Fahar for your help to figure out the actual issue.

Please find the updated patch.

I've added logging functionality in the process executor permanently.

Working as expected with the latest patch on my systems (OSX, and Window 10).

Thanks & Regards,

Ashesh Vashi

Kind Regards,

On Thu, Feb 2, 2017 at 11:22 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Sure Ashesh,

I will test and update the testing status accordingly.

On Thu, Feb 2, 2017 at 11:17 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Fahar,

Can you please test the updated patch?
I have fixed one issue on windows, and also added logging information in the background process execution for future issue analysis.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Jan 23, 2017 at 12:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I am using Administrator user on 2012 server . Can you please check this behavior on my machine through skype or google talk?

Regards,

On Mon, Jan 23, 2017 at 10:07 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected,

I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Jan 21, 2017 at 1:18 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

RM1679_v15.patch

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

From

Fahar Abbas

Date:

03 February 2017, 08:06:15

Hi Ashesh,

I tested this patch with Import/Export table, backup database, backup table, backup server and Backup global, it working fine. While in case of Restore database, it failed and "sequence item 6: expected string or Unicode, int found" message displayed.

Kind Regards

On Thu, Feb 2, 2017 at 9:14 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Thu, Feb 2, 2017 at 6:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi,

Currently Ashesh is working for the particular issue on my machine and he will share the updated patch on tomorrow.
Thanks Fahar for your help to figure out the actual issue.

Please find the updated patch.
I've added logging functionality in the process executor permanently.

Working as expected with the latest patch on my systems (OSX, and Window 10).

--
Thanks & Regards,

Ashesh Vashi

Kind Regards,

On Thu, Feb 2, 2017 at 11:22 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Sure Ashesh,

I will test and update the testing status accordingly.

On Thu, Feb 2, 2017 at 11:17 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Fahar,

Can you please test the updated patch?
I have fixed one issue on windows, and also added logging information in the background process execution for future issue analysis.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Jan 23, 2017 at 12:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I am using Administrator user on 2012 server . Can you please check this behavior on my machine through skype or google talk?

Regards,

On Mon, Jan 23, 2017 at 10:07 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected,

I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Jan 21, 2017 at 1:18 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Syed Fahar Abbas

Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Attachment

Screen Shot 2017-02-03 at 10.02.31 AM.png

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Ashesh Vashi

Date:

03 February 2017, 08:11:13

Can you please create a separate RM for the same, and assign it to me?

And, please attach the pgadmin logs (only the relevant logs).

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Fri, Feb 3, 2017 at 10:36 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

Hi Ashesh,

I tested this patch with Import/Export table, backup database, backup table, backup server and Backup global, it working fine. While in case of Restore database, it failed and "sequence item 6: expected string or Unicode, int found" message displayed.

Kind Regards

On Thu, Feb 2, 2017 at 9:14 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Feb 2, 2017 at 6:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi,

Currently Ashesh is working for the particular issue on my machine and he will share the updated patch on tomorrow.
Thanks Fahar for your help to figure out the actual issue.

Please find the updated patch.
I've added logging functionality in the process executor permanently.

Working as expected with the latest patch on my systems (OSX, and Window 10).

--
Thanks & Regards,

Ashesh Vashi

Kind Regards,

On Thu, Feb 2, 2017 at 11:22 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Sure Ashesh,

I will test and update the testing status accordingly.

On Thu, Feb 2, 2017 at 11:17 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Fahar,

Can you please test the updated patch?
I have fixed one issue on windows, and also added logging information in the background process execution for future issue analysis.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Jan 23, 2017 at 12:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I am using Administrator user on 2012 server . Can you please check this behavior on my machine through skype or google talk?

Regards,

On Mon, Jan 23, 2017 at 10:07 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected,

I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Jan 21, 2017 at 1:18 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Fahar Abbas

Date:

03 February 2017, 08:32:43

RM reported:
https://redmine.postgresql.org/issues/2144

On Fri, Feb 3, 2017 at 10:11 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Can you please create a separate RM for the same, and assign it to me?
And, please attach the pgadmin logs (only the relevant logs).

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Fri, Feb 3, 2017 at 10:36 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Ashesh,

I tested this patch with Import/Export table, backup database, backup table, backup server and Backup global, it working fine. While in case of Restore database, it failed and "sequence item 6: expected string or Unicode, int found" message displayed.

Kind Regards

On Thu, Feb 2, 2017 at 9:14 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Feb 2, 2017 at 6:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi,

Currently Ashesh is working for the particular issue on my machine and he will share the updated patch on tomorrow.
Thanks Fahar for your help to figure out the actual issue.

Please find the updated patch.
I've added logging functionality in the process executor permanently.

Working as expected with the latest patch on my systems (OSX, and Window 10).

--
Thanks & Regards,

Ashesh Vashi

Kind Regards,

On Thu, Feb 2, 2017 at 11:22 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Sure Ashesh,

I will test and update the testing status accordingly.

On Thu, Feb 2, 2017 at 11:17 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Fahar,

Can you please test the updated patch?
I have fixed one issue on windows, and also added logging information in the background process execution for future issue analysis.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Jan 23, 2017 at 12:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I am using Administrator user on 2012 server . Can you please check this behavior on my machine through skype or google talk?

Regards,

On Mon, Jan 23, 2017 at 10:07 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected,

I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Jan 21, 2017 at 1:18 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Syed Fahar Abbas

Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Ashesh Vashi

Date:

03 February 2017, 18:40:14

Hi Dave,

Please find the patch with fix for the 2144.

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Fri, Feb 3, 2017 at 11:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:

RM reported:
https://redmine.postgresql.org/issues/2144

On Fri, Feb 3, 2017 at 10:11 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Can you please create a separate RM for the same, and assign it to me?
And, please attach the pgadmin logs (only the relevant logs).

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Fri, Feb 3, 2017 at 10:36 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Ashesh,

I tested this patch with Import/Export table, backup database, backup table, backup server and Backup global, it working fine. While in case of Restore database, it failed and "sequence item 6: expected string or Unicode, int found" message displayed.

Kind Regards

On Thu, Feb 2, 2017 at 9:14 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Feb 2, 2017 at 6:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi,

Currently Ashesh is working for the particular issue on my machine and he will share the updated patch on tomorrow.
Thanks Fahar for your help to figure out the actual issue.

Please find the updated patch.
I've added logging functionality in the process executor permanently.

Working as expected with the latest patch on my systems (OSX, and Window 10).

--
Thanks & Regards,

Ashesh Vashi

Kind Regards,

On Thu, Feb 2, 2017 at 11:22 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Sure Ashesh,

I will test and update the testing status accordingly.

On Thu, Feb 2, 2017 at 11:17 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Fahar,

Can you please test the updated patch?
I have fixed one issue on windows, and also added logging information in the background process execution for future issue analysis.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Jan 23, 2017 at 12:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I am using Administrator user on 2012 server . Can you please check this behavior on my machine through skype or google talk?

Regards,

On Mon, Jan 23, 2017 at 10:07 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected,

I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Jan 21, 2017 at 1:18 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Attachment

RM1679_v16.patch

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for"restore" not reporting status back to pgAdmin

From

Dave Page

Date:

04 February 2017, 17:27:22

Thanks - applied with some minor UI and string tweaks.

On Fri, Feb 3, 2017 at 3:40 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Dave,

Please find the patch with fix for the 2144.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Fri, Feb 3, 2017 at 11:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
RM reported:
https://redmine.postgresql.org/issues/2144

On Fri, Feb 3, 2017 at 10:11 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Can you please create a separate RM for the same, and assign it to me?
And, please attach the pgadmin logs (only the relevant logs).

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Fri, Feb 3, 2017 at 10:36 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Ashesh,

I tested this patch with Import/Export table, backup database, backup table, backup server and Backup global, it working fine. While in case of Restore database, it failed and "sequence item 6: expected string or Unicode, int found" message displayed.

Kind Regards

On Thu, Feb 2, 2017 at 9:14 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Feb 2, 2017 at 6:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi,

Currently Ashesh is working for the particular issue on my machine and he will share the updated patch on tomorrow.
Thanks Fahar for your help to figure out the actual issue.

Please find the updated patch.
I've added logging functionality in the process executor permanently.

Working as expected with the latest patch on my systems (OSX, and Window 10).

--
Thanks & Regards,

Ashesh Vashi

Kind Regards,

On Thu, Feb 2, 2017 at 11:22 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Sure Ashesh,

I will test and update the testing status accordingly.

On Thu, Feb 2, 2017 at 11:17 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Fahar,

Can you please test the updated patch?
I have fixed one issue on windows, and also added logging information in the background process execution for future issue analysis.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Jan 23, 2017 at 12:19 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I am using Administrator user on 2012 server . Can you please check this behavior on my machine through skype or google talk?

Regards,

On Mon, Jan 23, 2017 at 10:07 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected,

I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Jan 21, 2017 at 1:18 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+.

Please confirm?

On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Murtaza,

I just applied this patch and issue is still not resolved.

In case of Maintenance DB and Backup database message, Maintenance job created and Backup job created displayed but no other dialogue box displayed either process is completed or not.

Screen-shot and pgadmin.log file is attached.

Kind Regards,

On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Fahar,

Could you please test this updated patch?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Thanks Dave.

On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto.

On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Issue is also reproducible with PG-9.6 server.

Regards,

On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Please attached the log files output from the terminal and pgAdmin4.log.

Kind Regards,

On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage@pgadmin.org> wrote:

KeyError: u'end_time'

The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}

Thanks for reviewing the patch.
Please find the updated patch.

Changes:
- Using now ValueError instead of json.JSONDecodeError, which is subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.

That seems to work for me in a brief test on my Mac. :-)

Fahar; are you able to apply and test this patch on Windows and Linux, in server and desktop modes? Basically all the external processes should be tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs available at the moment due to travel.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company