Re: Improve pg_stat_statements by making jumble handle savepoint names better - Mailing list pgsql-hackers

From Greg Sabino Mullane
Subject Re: Improve pg_stat_statements by making jumble handle savepoint names better
Date
Msg-id CAKAnmmJE8iSq7gubE7r=y6vqfv9VO-VfHxFFSvQoUJpnS_4OvA@mail.gmail.com
Whole thread Raw
In response to Re: Improve pg_stat_statements by making jumble handle savepoint names better  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Improve pg_stat_statements by making jumble handle savepoint names better
List pgsql-hackers
On Mon, Jul 24, 2023 at 6:46 PM Michael Paquier <michael@paquier.xyz> wrote:
Shouldn't this new field be marked as query_jumble_location
 
Yes, it should. I had some trouble getting it to work that way in the first place, but now I realize it was just my unfamiliarity with this part of the code. So thanks for the hint: v2 of the patch is much simplified by adding two attributes to theTransactionStmt node. I've also added some tests per your suggestion.

Unrelated to this patch, I'm struggling with meson testing. Why doesn't this update the postgres test binary?:

meson test --suite pg_stat_statements

It runs "ninja" as expected, but it does not put a new 
build/tmp_install/home/greg/pg/17/bin/postgres in place until I do a "meson test"

Cheers,
Greg

Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: logical decoding and replication of sequences, take 2
Next
From: Andres Freund
Date:
Subject: Re: WAL Insertion Lock Improvements