Re: EXPLAIN IndexOnlyScan shows disabled when enable_indexonlyscan=on - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: EXPLAIN IndexOnlyScan shows disabled when enable_indexonlyscan=on
Date
Msg-id CAKFQuwa6M_Hd0LX2xi3SPUvXaAqKCpn8Tnj6F=-jJZ9Avh0Chw@mail.gmail.com
Whole thread Raw
In response to EXPLAIN IndexOnlyScan shows disabled when enable_indexonlyscan=on  (Melanie Plageman <melanieplageman@gmail.com>)
Responses Re: EXPLAIN IndexOnlyScan shows disabled when enable_indexonlyscan=on
List pgsql-hackers
On Mon, Oct 28, 2024 at 3:54 PM David Rowley <dgrowleyml@gmail.com> wrote:

I've attached that in patch form.


 -        Enables or disables the query planner's use of index-scan plan
-        types. The default is <literal>on</literal>.
+        Enables or disables the query planner's use of index-scan and
+        index-only-scan plan types.  The default is <literal>on</literal>.
+        Also see <xref linkend="guc-enable-indexonlyscan"/>.

I think the original wording "index-scan plan types" is what is confusing me.  The plural types is turning index-scan plan into a category of plans rather than the single plan type "index scan".

Your proposed wording actually (accidentally?) fixes this because now the plural types actually refers to two individual plan nodes, "index scan" and "index-only scan".

The hyphenation still reads a bit odd but ok.

I am ok with this revision (and the patch as a whole) I suppose but I still feel like something is missing here.  Though probably that something would fit better in an overview page rather than trying to get the settings to explain all this to the reader.

David J.
 

pgsql-hackers by date:

Previous
From: Andy Fan
Date:
Subject: Re: detoast datum into the given buffer as a optimization.
Next
From: Peter Smith
Date:
Subject: Re: Pgoutput not capturing the generated columns