Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Date
Msg-id CAKFQuwacztouhg4mgSG7r8AFSMYiSqRb0aq=meZUgEr3YP9wSA@mail.gmail.com
Whole thread Raw
In response to Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.  (Shubham Khanna <khannashubham1197@gmail.com>)
Responses Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
List pgsql-hackers
On Monday, March 17, 2025, Shubham Khanna <khannashubham1197@gmail.com> wrote:

I have added validation for "all" to address both issues at once.


Usage needs to be changed to refer to object types and we should try and specify which are valid there too.

The sgml docs need to mention “all” as a valid value and what it means (namely, if new object types are added and “all” is specified those new types will be removed as well).  Suggest not using it in scripts.

There are still more places where “object type” is needed instead of just “object”.  I’ll pin-point or fix tomorrow if you don’t beat me to them.

It would be good if we could get this to play nicely with —dry-run; maybe connecting to the source for the queries instead of the target.  That would help alleviate my issue with the current auto-drop behavior.

David J.

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: maintenance_work_mem = 64kB doesn't work for vacuum
Next
From: Amit Kapila
Date:
Subject: Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.