Re: vacuum_cost_limit doc description patch - Mailing list pgsql-hackers

From David Rowley
Subject Re: vacuum_cost_limit doc description patch
Date
Msg-id CAKJS1f9ofABS2C=nvpfhsQxZdiR=b_6FjKRnoUkM1wPnzhA+7Q@mail.gmail.com
Whole thread Raw
In response to vacuum_cost_limit doc description patch  (Martín Marqués <martin.marques@gmail.com>)
Responses Re: vacuum_cost_limit doc description patch
List pgsql-hackers
On 11 April 2018 at 09:13, Martín Marqués <martin.marques@gmail.com> wrote:
> This is a patch to add some further description, plus the upper and
> lower limits it has.

Hi,

+         for vacuum_cost_delay. The parameter can take a value
between 1 and 10000.

vacuum_cost_delay should be in <varname> tags.

+1 to mentioning that we sleep for vacuum_cost_delay, but I just don't
see many other GUCs with mention of their supported range.

effective_io_concurrency mentions the range it supports, but this
happens to depend on USE_POSIX_FADVISE, which if undefined the maximum
setting is 0, which means the docs are wrong in some cases on that.

vacuum_cost_limit seems fairly fixed at 0-10000 with no compile-time
conditions, so perhaps it's okay, providing we remember and update the
docs if that ever changes.

--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Boolean partitions syntax
Next
From: Amit Langote
Date:
Subject: Re: Boolean partitions syntax