Re: [pgAdmin4][Patch]: To fix the issue in Debugger module - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: [pgAdmin4][Patch]: To fix the issue in Debugger module
Date
Msg-id CAKKotZSFF3v5Ln+ATMX33H0_nR7H903sY97pyksk+kk4eSWLug@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: To fix the issue in Debugger module  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin4][Patch]: To fix the issue in Debugger module
List pgadmin-hackers
Hi Dave,

PFA updated patch.

On Sat, Dec 2, 2017 at 10:42 AM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thursday, November 30, 2017, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where debugger failed to run when user tries to debug the function which call itself recursively.
RM#2524

This seems to fix the recursion problem, but walking the stack doesn't work - no matter which frame I click on, the highlighted source code line remains that of the top frame, as does the value of in_val on the Parameters tab.
​Fixed.​
 
​It's due to improper conditional logic to select frame id in JS code.​
 

Thanks.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Attachment

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tableswith OIDs but no primary key
Next
From: Murtuza Zabuawala
Date:
Subject: [pgAdmin4][Patch]: To fix the issue in File manager