Re: GIN pageinspect support for entry tree and posting tree - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: GIN pageinspect support for entry tree and posting tree
Date
Msg-id CALdSSPg6cqqWNDkAWX0RfB7CXM+oxacHivHPa90dZtX27KBGLg@mail.gmail.com
Whole thread Raw
In response to Re: GIN pageinspect support for entry tree and posting tree  (Japin Li <japinli@hotmail.com>)
Responses Re: GIN pageinspect support for entry tree and posting tree
List pgsql-hackers
On Wed, 14 Jan 2026 at 07:19, Japin Li <japinli@hotmail.com> wrote:
>
> On Sun, 11 Jan 2026 at 21:43, Andrey Borodin <x4mmm@yandex-team.ru> wrote:
> >> On 10 Jan 2026, at 19:17, Kirill Reshke <reshkekirill@gmail.com> wrote:
> >>
> >> So,
> >> v14-0004 with this change attached.
> >
> > Did you mean 0003?
> >
> > The change makes sense, but I'd note that macro is always used like this:
> >
> > if (!IS_INDEX(indexRel) || !IS_HASH(indexRel))
> >
> > If we are refactoring this, maybe put IS_INDEX inside of corresponding IS_BTREE(),IS_GIN() and IS_HASH()?
> >
>
> +1
>
> Attach the v15 patch.
> v15-0001 and v15-0002 unchanged and v15-0003 changed as above.
>
> --
> Regards,
> Japin Li
> ChengDu WenWu Information Technology Co., Ltd.
>

Hi! Thank you 🙏 for your effort. 0003 looks good to me

--
Best regards,
Kirill Reshke



pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Segmentation fault on proc exit after dshash_find_or_insert
Next
From: Amit Kapila
Date:
Subject: Re: Simplify code building the LR conflict messages