Re: GIN pageinspect support for entry tree and posting tree - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: GIN pageinspect support for entry tree and posting tree
Date
Msg-id CALdSSPivsz8FH3p68dRnEtruvsA+9FQqYB_WXpcNY6BLT19N4g@mail.gmail.com
Whole thread Raw
In response to Re: GIN pageinspect support for entry tree and posting tree  (Roman Khapov <rkhapov@yandex-team.ru>)
List pgsql-hackers
On Wed, 14 Jan 2026 at 17:44, Roman Khapov <rkhapov@yandex-team.ru> wrote:
>
>
> > I agree — the NULL handling seems wrong.
> > Here's a quick patch to fix it. What do you think?
>
> LGTM, but maybe the test should be expanded with NULL for the two-column
> indexes? I mean to add NULLs at zero column too.
>
> Also, about the tests but not related to NULLs...
> Seems like we need to run those tests on 32bit system, the test output should be different?

Yes, gin_1.out is for 32-bit output. Adding new tuples in relation
will result in binary layout changes, so we need to update gin.out for
64 bit and gin_1.out for 32 bit




--
Best regards,
Kirill Reshke



pgsql-hackers by date:

Previous
From: Roman Khapov
Date:
Subject: Re: GIN pageinspect support for entry tree and posting tree
Next
From: Kirill Reshke
Date:
Subject: Re: Add IS_INDEX macro to brin and gist index