Request a Demo
Home   >   mailing lists

Re: GIN pageinspect support for entry tree and posting tree - Mailing list pgsql-hackers

From Roman Khapov
Subject Re: GIN pageinspect support for entry tree and posting tree
Date
Msg-id 9CFF5492-B542-4BE7-9093-E32EBC7DDB1C@yandex-team.ru
Whole thread Raw
In response to Re: GIN pageinspect support for entry tree and posting tree  (Japin Li <japinli@hotmail.com>)
Responses Re: GIN pageinspect support for entry tree and posting tree
Re: GIN pageinspect support for entry tree and posting tree
List pgsql-hackers
Tree view 
> I agree — the NULL handling seems wrong.
> Here's a quick patch to fix it. What do you think?

LGTM, but maybe the test should be expanded with NULL for the two-column
indexes? I mean to add NULLs at zero column too.

Also, about the tests but not related to NULLs...
Seems like we need to run those tests on 32bit system, the test output should be different?

--
Best regards,
Roman Khapov

pgsql-hackers by date:

Previous
From: Kirill Reshke
Date:
Subject: Re: GIN pageinspect support for entry tree and posting tree
Next
From: Kirill Reshke
Date:
Subject: Re: GIN pageinspect support for entry tree and posting tree