On Thu, 27 Nov 2025 at 10:38, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Nov 27, 2025 at 09:35:14AM +0200, Heikki Linnakangas wrote:
> > This doesn't really feel like an improvement to me, sequence.c is small
> > enough as is it is. If this helps with the other work you're doing though,
> > no objections.
>
> Yes, it does for the sequence AM patch where I'm splitting the
> sequence WAL APIs from the "core" sequence computation logic.
> --
> Michael
Hi!
Shouldnt `SEQ_LOG_VALS` be moved to sequnce_xlog.c ?
Also, while on it, maybe it is worth to rename xl_seq_rec struct to
something. It will be more convietinet to make a name in sync with the
XLOG_SEQ_LOG WAL record (like we do in heapxlog). Maybe struct
xl_seq_log ?
--
Best regards,
Kirill Reshke
