Request a Demo
Home   >   mailing lists

Re: Move WAL/RMGR sequence code into its own file and header - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Move WAL/RMGR sequence code into its own file and header
Date
Msg-id aSkfo8MTspUnlkt-@paquier.xyz
Whole thread Raw
In response to Re: Move WAL/RMGR sequence code into its own file and header  (Kirill Reshke <reshkekirill@gmail.com>)
List pgsql-hackers
Tree view 
On Thu, Nov 27, 2025 at 12:00:30PM +0300, Kirill Reshke wrote:
> Shouldnt `SEQ_LOG_VALS` be moved to sequnce_xlog.c ?

I am not sure to follow this one.  This controls the frequency of the
records inserted, which has nothing to do with the redo path.

> Also, while on it, maybe it is worth to rename xl_seq_rec struct to
> something. It will be more convenient to make a name in sync with the
> XLOG_SEQ_LOG WAL record (like we do in heapxlog).  Maybe struct
> xl_seq_log ?

I am not sure to see the value in a rename for the scope of this
patch, sequence.h already published them.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Fix a recent "shadow warning" in subscriptioncmds.c
Next
From: jian he
Date:
Subject: extend JSON_TABLE top level path expression