Re: GIN pageinspect support for entry tree and posting tree - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: GIN pageinspect support for entry tree and posting tree
Date
Msg-id CALdSSPjgB2=cn2KsMSYD=55ft1kWv0xThNT7+eDHmPtGOuKo5w@mail.gmail.com
Whole thread Raw
In response to Re: GIN pageinspect support for entry tree and posting tree  (Japin Li <japinli@hotmail.com>)
List pgsql-hackers
On Wed, 14 Jan 2026 at 19:51, Japin Li <japinli@hotmail.com> wrote:
>
> On Wed, 14 Jan 2026 at 17:44, Roman Khapov <rkhapov@yandex-team.ru> wrote:
> >> I agree — the NULL handling seems wrong.
> >> Here's a quick patch to fix it. What do you think?
> >
> > LGTM, but maybe the test should be expanded with NULL for the two-column
> > indexes? I mean to add NULLs at zero column too.
> >
>
> Sorry, I’m not sure I understand.
>
> Are you suggesting we add one (or both) of these test cases?
>
> INSERT INTO test1 VALUES (2, NULL, NULL);
> INSERT INTO test1 VALUES (2, ARRAY[NULL, 222], ARRAY['d', NULL]);
>

Yes, like this, to have gin_entrypage_items to output y=NULL and
z=NULL for y_z index



--
Best regards,
Kirill Reshke



pgsql-hackers by date:

Previous
From: Japin Li
Date:
Subject: Re: Add IS_INDEX macro to brin and gist index
Next
From: Japin Li
Date:
Subject: Re: GIN pageinspect support for entry tree and posting tree