On Wed, 14 Jan 2026 at 19:51, Japin Li <japinli@hotmail.com> wrote:
>
> On Wed, 14 Jan 2026 at 17:44, Roman Khapov <rkhapov@yandex-team.ru> wrote:
> >> I agree — the NULL handling seems wrong.
> >> Here's a quick patch to fix it. What do you think?
> >
> > LGTM, but maybe the test should be expanded with NULL for the two-column
> > indexes? I mean to add NULLs at zero column too.
> >
>
> Sorry, I’m not sure I understand.
>
> Are you suggesting we add one (or both) of these test cases?
>
> INSERT INTO test1 VALUES (2, NULL, NULL);
> INSERT INTO test1 VALUES (2, ARRAY[NULL, 222], ARRAY['d', NULL]);
>
Yes, like this, to have gin_entrypage_items to output y=NULL and
z=NULL for y_z index
--
Best regards,
Kirill Reshke