Re: GIN pageinspect support for entry tree and posting tree - Mailing list pgsql-hackers

From Japin Li
Subject Re: GIN pageinspect support for entry tree and posting tree
Date
Msg-id SYAPR01MB303853F66A53ED2297560915B68FA@SYAPR01MB3038.ausprd01.prod.outlook.com
Whole thread Raw
In response to Re: GIN pageinspect support for entry tree and posting tree  (Roman Khapov <rkhapov@yandex-team.ru>)
Responses Re: GIN pageinspect support for entry tree and posting tree
Re: GIN pageinspect support for entry tree and posting tree
List pgsql-hackers
On Wed, 14 Jan 2026 at 17:44, Roman Khapov <rkhapov@yandex-team.ru> wrote:
>> I agree — the NULL handling seems wrong.
>> Here's a quick patch to fix it. What do you think?
>
> LGTM, but maybe the test should be expanded with NULL for the two-column
> indexes? I mean to add NULLs at zero column too.
>

Sorry, I’m not sure I understand.

Are you suggesting we add one (or both) of these test cases?

INSERT INTO test1 VALUES (2, NULL, NULL);
INSERT INTO test1 VALUES (2, ARRAY[NULL, 222], ARRAY['d', NULL]);

> Also, about the tests but not related to NULLs...
> Seems like we need to run those tests on 32bit system, the test output should be different?
>

Agree.

--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: remove pg_restrict workaround
Next
From: Japin Li
Date:
Subject: Re: Add IS_INDEX macro to brin and gist index